Date: Sun, 1 Dec 2013 12:28:14 +0000 From: David Chisnall <theraven@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Eitan Adler <eadler@FreeBSD.org> Subject: Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm Message-ID: <A421C52D-6D4B-4C1D-B17A-6BA908A8E74E@FreeBSD.org> In-Reply-To: <20131201075944.GF59496@kib.kiev.ua> References: <201311302216.rAUMGcPA037268@svn.freebsd.org> <20131201075944.GF59496@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
On 1 Dec 2013, at 07:59, Konstantin Belousov <kostikbel@gmail.com> wrote: > Revert the drm2/i915 changes from this and following commits now. > You did not contacted obvious maintainer of the file. > > The changes are pointless and make the import of upstream changes > harder; for i915_reg.h, much harder. > > Not to mention that the whole churn is not needed if the > -fno-strict-overflow flag is used. If supporting code that is obviously wrong (as in this case, as the compiler will happily tell you if you don't explicitly silence warnings) is the justification for wanting -fno-strict-overflow, then this is a very flimsy justification. Davidhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A421C52D-6D4B-4C1D-B17A-6BA908A8E74E>