Date: Tue, 18 Apr 2017 16:10:45 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Larry Rosenman <ler@lerctr.org>, Alan Somers <asomers@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r317061 - in head: libexec/rpc.rstatd sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/arm64/include sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/compat/linprocfs... Message-ID: <d20d96d2-ba3a-d7b5-2dd6-422d7ae67af9@FreeBSD.org> In-Reply-To: <D23809B2-BAFB-4748-A8CD-46983BB8FB91@lerctr.org> References: <201704171734.v3HHYlf5022945@repo.freebsd.org> <CAOtMX2jdNj0du0ZuUKPr16iHK_YeNVzf-nDvwC-MuFM003VVAg@mail.gmail.com> <D23809B2-BAFB-4748-A8CD-46983BB8FB91@lerctr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qAedvP919HHrE21Rbe7xcsRUUWgCqpORB Content-Type: multipart/mixed; boundary="uXAjQ36dFWv0KCKdvQmrTdt09c1v2uqFt"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: Larry Rosenman <ler@lerctr.org>, Alan Somers <asomers@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Message-ID: <d20d96d2-ba3a-d7b5-2dd6-422d7ae67af9@FreeBSD.org> Subject: Re: svn commit: r317061 - in head: libexec/rpc.rstatd sys/amd64/amd64 sys/amd64/include sys/arm/arm sys/arm/include sys/arm64/include sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/compat/linprocfs... References: <201704171734.v3HHYlf5022945@repo.freebsd.org> <CAOtMX2jdNj0du0ZuUKPr16iHK_YeNVzf-nDvwC-MuFM003VVAg@mail.gmail.com> <D23809B2-BAFB-4748-A8CD-46983BB8FB91@lerctr.org> In-Reply-To: <D23809B2-BAFB-4748-A8CD-46983BB8FB91@lerctr.org> --uXAjQ36dFWv0KCKdvQmrTdt09c1v2uqFt Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 04/18/2017 16:05, Larry Rosenman wrote: > On 4/18/17, 2:58 PM, "Alan Somers" <owner-svn-src-all@freebsd.org on be= half of asomers@freebsd.org> wrote: >=20 > On Mon, Apr 17, 2017 at 11:34 AM, Gleb Smirnoff <glebius@freebsd.or= g> wrote: > > Author: glebius > > Date: Mon Apr 17 17:34:47 2017 > > New Revision: 317061 > > URL: https://svnweb.freebsd.org/changeset/base/317061 > > > > Log: > > - Remove 'struct vmmeter' from 'struct pcpu', leaving only glob= al vmmeter > > in place. To do per-cpu stats, convert all fields that previ= ously were > > maintained in the vmmeters that sit in pcpus to counter(9). > > - Since some vmmeter stats may be touched at very early stages = of boot, > > before we have set up UMA and we can do counter_u64_alloc(), = provide an > > early counter mechanism: > > o Leave one spare uint64_t in struct pcpu, named pc_early_dum= my_counter. > > o Point counter(9) fields of vmmeter to pcpu[0].pc_early_dumm= y_counter, > > so that at early stages of boot, before counters are alloca= ted we already > > point to a counter that can be safely written to. > > o For sparc64 that required a whole dummy pcpu[MAXCPU] array.= > > > > Further related changes: > > - Don't include vmmeter.h into pcpu.h. > > - vm.stats.vm.v_swappgsout and vm.stats.vm.v_swappgsin changed = to 64-bit, > > to match kernel representation. > > - struct vmmeter hidden under _KERNEL, and only vmstat(1) is an= exclusion. > > > > This is based on benno@'s 4-year old patch: > > https://lists.freebsd.org/pipermail/freebsd-arch/2013-July/0144= 71.html > > > > Reviewed by: kib, gallatin, marius, lidl > > Differential Revision: https://reviews.freebsd.org/D1015= 6 > > > This change broke backwards compatibility with old top binaries. When > I use a kernel at version 317094 but a top from 14-April, I get the= > error "top: sysctl(vm.stats.vm.v_swappgsin...) failed: Cannot alloc= ate > memory". I get the same error when running top from an 11.0-RELEAS= E > jail. Can you please add backward compatibility shims? > =20 > -Alan > It also broke emulators/virtualbox-ose-kmod True but it is not a big deal. A patch will be committed with VirtualBox 5.1.20 soon. Jung-uk Kim --uXAjQ36dFWv0KCKdvQmrTdt09c1v2uqFt-- --qAedvP919HHrE21Rbe7xcsRUUWgCqpORB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlj2csoACgkQfJ+WJvzb 8UY3/Af8C7KB2038a0aFtZtpjXLFayP2TCXxYyqhgsld2HubTr47xSH5tDpJabS6 KVgXqfbcp/sibIgTq/m+AXUAZ9m2ntjToGI+7H7NsuCTTY4yzH+Arc2Z1RGRlfox rmH5QIreEZRh26ykeQ4Ee9u1tn/sMdrmL4KydN4fR4V3L7rm4Rx11ZUjBksCn6+d jU/zHovGs6KPE+zTj6tO0wrgRCu6KXvI0GlYRtJ5UH6xytnOgEdWRngSGSUIg8BW vWSb+DPN8NsrwhRdXq7PhupwmizKv/TBYKeppLHWbW778OAUx5HTRoaftmg15e0R OUKezAFFvy0F4+ZQzlYmmx2624CY/A== =36S3 -----END PGP SIGNATURE----- --qAedvP919HHrE21Rbe7xcsRUUWgCqpORB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d20d96d2-ba3a-d7b5-2dd6-422d7ae67af9>