Date: Thu, 3 May 2007 13:10:02 -0400 From: Kris Kennaway <kris@obsecurity.org> To: "Mikhail T." <mi+metlife@aldan.algebra.com> Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Kris Kennaway <kris@obsecurity.org>, Rong-en Fan <grafan@gmail.com>, cvs-all@freebsd.org, kientzle@freebsd.org, portmgr@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c Message-ID: <20070503171002.GA86430@xor.obsecurity.org> In-Reply-To: <4639E3D0.1050208@aldan.algebra.com> References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> <20070503062438.GA50698@xor.obsecurity.org> <4639E3D0.1050208@aldan.algebra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 03, 2007 at 09:29:52AM -0400, Mikhail T. wrote: > Kris Kennaway wrote: > >On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > > > >>Rong-en Fan wrote: > >> > >>>On 3/15/07, Colin Percival <cperciva@freebsd.org> wrote: > >>> > >>>> Modified files: > >>>> usr.bin/tar write.c > >>>> Log: > >>>> Don't consider an lstat(2) failure to be an error (in the sense of > >>>> affecting the return value from bsdtar) [...] > >>>> > >>>This commit makes 'make package' successfully even if the plist is > >>>wrong, i.e. it contains ``ghost'' files. Basically, > >>> > >>>$ tar zcvf a.tgz /aaa > >>>tar: /aaa: Cannot stat: No such file or directory > >>> > >>>It returns 0, so make package will be considered successful. > >>> > >>I've fixed this in revision 1.62. > >> > >>Colin Percival > >> > > > >Thanks, I think mi@ ran into this recently too. > > > So, this is fixed now? A bug is fixed, dunno off-hand it's the one you ran into. > I guess, the fears, that fixing it would require > fixing multitude of ports, were somewhat ungrounded. Relax, it was just a guess. Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070503171002.GA86430>