Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Feb 2010 16:51:08 -0500
From:      Wesley Shields <wxs@FreeBSD.org>
To:        Christer Solskogen <christer.solskogen@gmail.com>
Cc:        ports@freebsd.org
Subject:   Re: make package-noinstall does not include rc.d scripts?
Message-ID:  <20100220215108.GC66609@atarininja.org>
In-Reply-To: <c1a0d1561002200755q4ab28515ic550fca1789e1cd8@mail.gmail.com>
References:  <c1a0d1561002200755q4ab28515ic550fca1789e1cd8@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 20, 2010 at 04:55:58PM +0100, Christer Solskogen wrote:
> Hi!
> 
> I've just discovered the make option "make package-noinstall" which
> makes a tbz in /usr/ports/packages from a already installed package.
> But I've also found a bug(?) with that option. The package it creates
> seems not to include rc.d script which will be included if you use
> "make package"
> I've tried this now with two ports (stunnel and mysql51-server) - but
> I guess that it will happen to other ports as well.

I tested it with devel/git and it looks like a bug to me. I've got a
patch which should fix it[1]. It's basically a copy/paste of the
install-rc-script target into the do-package target and removing the two
lines that actually install the script.

A better solution may be to have one target install the rc script and
one target add it to the plist. That way the add-to-plist target can be
effectively shared. Minimizing the chances that changes in one do not
reflect into the other.

Does anyone have any opinions on this? If not I'll open a PR for
portmgr.

[1]: http://people.freebsd.org/~wxs/package-noinstall-rc-script.diff

-- WXS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100220215108.GC66609>