Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 May 2024 13:26:47 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: b6a2ce76d6b6 - stable/14 - udf: uma_zcreate() does not fail
Message-ID:  <202405021326.442DQlZY080820@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=b6a2ce76d6b60bb363f6b83559c0d5e19027cad9

commit b6a2ce76d6b60bb363f6b83559c0d5e19027cad9
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-04-23 16:20:50 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-05-02 13:25:08 +0000

    udf: uma_zcreate() does not fail
    
    While here remove an old comment regarding preallocation; it appears to
    refer to an optimization that is almost certainly irrelevant at this
    point.
    
    No functional change intended.
    
    MFC after:      1 week
    
    (cherry picked from commit 78c51db3c4927db2437ec616b33ba1faf73f08ee)
---
 sys/fs/udf/udf_vfsops.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/sys/fs/udf/udf_vfsops.c b/sys/fs/udf/udf_vfsops.c
index e844a4e540f4..866d0172f745 100644
--- a/sys/fs/udf/udf_vfsops.c
+++ b/sys/fs/udf/udf_vfsops.c
@@ -140,11 +140,6 @@ static int
 udf_init(struct vfsconf *foo)
 {
 
-	/*
-	 * This code used to pre-allocate a certain number of pages for each
-	 * pool, reducing the need to grow the zones later on.  UMA doesn't
-	 * advertise any such functionality, unfortunately =-<
-	 */
 	udf_zone_trans = uma_zcreate("UDF translation buffer, zone", MAXNAMLEN *
 	    sizeof(unicode_t), NULL, NULL, NULL, NULL, 0, 0);
 
@@ -154,12 +149,6 @@ udf_init(struct vfsconf *foo)
 	udf_zone_ds = uma_zcreate("UDF Dirstream zone",
 	    sizeof(struct udf_dirstream), NULL, NULL, NULL, NULL, 0, 0);
 
-	if ((udf_zone_node == NULL) || (udf_zone_trans == NULL) ||
-	    (udf_zone_ds == NULL)) {
-		printf("Cannot create allocation zones.\n");
-		return (ENOMEM);
-	}
-
 	return 0;
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202405021326.442DQlZY080820>