Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Jun 2024 04:50:31 GMT
From:      Zhenlei Huang <zlei@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 2472e352d80f - stable/14 - icmp: correct the assertion that checks limit + jitter
Message-ID:  <202406260450.45Q4oVvE064103@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=2472e352d80fcf6440fd42fbb16960cc49d05b03

commit 2472e352d80fcf6440fd42fbb16960cc49d05b03
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-04-08 23:54:19 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2024-06-26 04:48:45 +0000

    icmp: correct the assertion that checks limit + jitter
    
    Fixes:  4399e055ea610cdefa1470ad1ee614dd81ba5e56
    (cherry picked from commit f7c4d12bcd5bd7f7fbf6bf9fa601c47e7f97bc5f)
---
 sys/netinet/ip_icmp.c | 2 +-
 sys/netinet6/icmp6.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netinet/ip_icmp.c b/sys/netinet/ip_icmp.c
index 67fb56dcdfa2..5ad1b2a664db 100644
--- a/sys/netinet/ip_icmp.c
+++ b/sys/netinet/ip_icmp.c
@@ -1150,7 +1150,7 @@ sysctl_icmplim_and_jitter(SYSCTL_HANDLER_ARGS)
 			}
 		}
 	}
-	MPASS(V_icmplim + V_icmplim_curr_jitter > 0);
+	MPASS(V_icmplim + V_icmplim_curr_jitter >= 0);
 
 	return (error);
 }
diff --git a/sys/netinet6/icmp6.c b/sys/netinet6/icmp6.c
index c03c90e566c3..d6e47a29eede 100644
--- a/sys/netinet6/icmp6.c
+++ b/sys/netinet6/icmp6.c
@@ -2819,7 +2819,7 @@ sysctl_icmp6lim_and_jitter(SYSCTL_HANDLER_ARGS)
 			}
 		}
 	}
-	MPASS(V_icmp6errppslim + V_icmp6lim_curr_jitter > 0);
+	MPASS(V_icmp6errppslim + V_icmp6lim_curr_jitter >= 0);
 
 	return (error);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202406260450.45Q4oVvE064103>