Date: Sat, 27 Oct 2001 07:20:01 -0700 (PDT) From: Roman Kurakin <rik@cronyx.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/21771: Fix for sppp and Cronyx drivers update Message-ID: <200110271420.f9REK1646377@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/21771; it has been noted by GNATS.
From: Roman Kurakin <rik@cronyx.ru>
To: freebsd-gnats-submit@FreeBSD.org
Cc: rik@cronyx.ru
Subject: Re: kern/21771: Fix for sppp and Cronyx drivers update
Date: Sat, 27 Oct 2001 18:16:22 +0400
-------- Original Message --------
Subject: kern/11238, kern/14848, kern/21771, sppp patch's patch_id #1
Date: Sat, 27 Oct 2001 18:06:51 +0400
From: Roman Kurakin <rik@cronyx.ru>
To: freebsd-net@FreeBSD.org
CC: Serge Vakulenko <vak@cronyx.ru>, mike@FreeBSD.org,
freebsd-bugs@FreeBSD.org, julian@FreeBSD.org, archie@FreeBSD.org,
joerg@FreeBSD.org, rik@cronyx.ru
References: <000901c1134b$827a69a0$48b5ce90@crox>
Hi,
This is the first patch of set of patches that I plan to make. These
patches ware send several
times as a big patch and last one wasn't even discussed. So I will try
to send them by small
pieces and will try to comment them.
Last one big patch was kern/21771. Last our version of sppp and
adapter drivers could be found
at http://www.cronyx.ru/software/
First portion contains following changes:
1) Just a header changes.
2) Changes like that:
case STATE_CLOSING:
- sppp_cp_change_state(cp, sp, STATE_CLOSED);
(cp->tlf)(sp);
+ sppp_cp_change_state(cp, sp, STATE_CLOSED);
break;
Comment:
If you change state at first and then call tlf you will get wrong
final state cause tlf will
lead to "Close" event and you will get (for this example) final state
"Initial".
In some cases this isn't so fatal but in other this will put out of
action a link.
All this changes was made according to RFC1661.
Best regards,
Roman Kurakin, Software Engineer,
Cronyx Engineering
>>Synopsis: Frame Relay support, corrected
>>
>>State-Changed-From-To: open->suspended
>>State-Changed-By: mike
>>State-Changed-When: Fri Jul 20 19:54:47 PDT 2001
>>State-Changed-Why:
>>
>>With a little bit of work, this could probably be committed.
>>Awaiting committer.
>>
>>http://www.FreeBSD.org/cgi/query-pr.cgi?pr=14848
>>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110271420.f9REK1646377>