Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Mar 2007 15:39:26 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        "Attilio Rao" <attilio@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org>, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/share/man/man9 Makefile condvar.9 lock.9 mi_switch.9 mtx_pool.9 mutex.9 rwlock.9 sleep.9 sleepqueue.9 sx.9 thread_exit.9 src/sys/kern kern_synch.c src/sys/sys mutex.h rwlock.h sleepqueue.h sx.h systm.h
Message-ID:  <200703121539.27016.jhb@freebsd.org>
In-Reply-To: <3bbf2fe10703120936w1909c744uc36ca1c030e76b6@mail.gmail.com>
References:  <200703092241.l29Mf2Ds062856@repoman.freebsd.org> <200703121114.59859.jhb@freebsd.org> <3bbf2fe10703120936w1909c744uc36ca1c030e76b6@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 12 March 2007 12:36, Attilio Rao wrote:
> > So you still get type checking, etc.  I'm thinking maybe the simplest 
thing to
> > do is to rename 'mtx_object', 'rw_object', and 'sx_object' fields to all
> > be 'lock_object' and then do this:
> 
> Even if this idea is not so bad (beacause we primitives are in a small
> and controlled number of them) we have a lot of places to update for
> that. A macro could be a temporary help, btw.

They are actually not very widespread at all, most uses are in macros in the 
headers or in the lock code itself.  Nothing M-% in xemacs can't handle. :)

% kgrep -l -E '(mtx|rw|sx)_object'
kern/kern_condvar.c
kern/kern_exit.c
kern/kern_kse.c
kern/kern_sig.c
kern/kern_lock.c
kern/kern_mutex.c
kern/kern_rwlock.c
kern/kern_sx.c
kern/kern_synch.c
kern/subr_witness.c
sys/_mutex.h
sys/_rwlock.h
sys/lock.h
sys/mutex.h
sys/rwlock.h
sys/sx.h
sys/proc.h
sys/systm.h

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200703121539.27016.jhb>