Date: Sat, 20 Jan 2024 19:30:55 -0500 From: "Mikhail T." <mi+t@virtual-estates.net> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple Message-ID: <f74f9837-121e-47ac-819b-27a40d3b4891@virtual-estates.net> In-Reply-To: <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com> References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------Gn05ibThosslzv8oYJUWh40I Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 20.01.24 17:15, Daniel Engberg: > Please at least enable DEVELOPER=yes and fix any warnings Why? How would that help anything? > Use the standard definition for POSTGRES, PGSQL > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410 Ok, I renamed the option. But the description is still port-specific... > SQLITE option is broken > "post-patch-SQLIT3-off" Ah, thanks! > > Overall ordering in Makefile can be improved portlint only mentions the patch being manually created... > LDFLAGS can probably be replaced with USES= localbase:ldflags Indeed! > > Configure logs suggests that USES= pkgconfig should be added Neah. Upstream's cmake-file tries to use pkgconfig to find libpurple. But it does not work anyway -- and the port supplies definitions for all the of the relevant cmake variables. > > It also fails to build > > https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log > So it does... But the failure is not due to anything you mentioned, but because of go's inability to download the additional modules, that the software wants: go: finding module for package go.mau.fi/whatsmeow/store github.com/hoehermann/purple-gowhatsapp/src/go imports github.com/alfg/mp4: module github.com/alfg/mp4: Get"https://proxy.golang.org/github.com/alfg/mp4/@v/list": dial tcp: lookup proxy.golang.org on 199.115.205.169:53: write udp 127.0.0.1:54689->199.115.205.169:53: write: permission denied Perhaps, that's because downloading during build is a no-no... I did e-mail maintainers of the Uses/go.mk last night seeking suggestions about this. There was no reply, so I decided to commit it -- and asked for help. Which helping would be easier, if the helper(s) could just commit an improvement... > If you're unsure please consider to create a review / PR instead of > just committing. Sorry, but what's the difference? Was Production Support woken up somewhere by a Level-1 alert due to the build-failure? > Please back this out for now. The only good reason to back out a change is when it breaks something else. Which this one didn't... I'll try to fix it, of course -- and if someone can help me with predownloading the Go-modules, that'd be great (Maven-using ports must dealing with that somehow...) But why would you want it backed out?! -mi --------------Gn05ibThosslzv8oYJUWh40I Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">20.01.24 17:15, Daniel Engberg:<br> </div> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div>Please at least enable DEVELOPER=yes and fix any warnings<br> </div> </blockquote> <p><br> </p> <p>Why? How would that help anything?<br> </p> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div>Use the standard definition for POSTGRES, PGSQL<br> </div> <div><a href="https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410" target="_blank" rel="noopener noreferrer" data-ik="ik-secure" moz-do-not-send="true" class="moz-txt-link-freetext">https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n410</a><br>; </div> </blockquote> <p>Ok, I renamed the option. But the description is still port-specific...<br> </p> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div>SQLITE option is broken<br> </div> <div>"post-patch-SQLIT3-off"<br> </div> </blockquote> Ah, thanks!<br> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div> <div><br> </div> </div> <div>Overall ordering in Makefile can be improved</div> </blockquote> portlint only mentions the patch being manually created...<br> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div>LDFLAGS can probably be replaced with USES= localbase:ldflags<br> </div> </blockquote> Indeed!<br> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div> <div><br> </div> <div>Configure logs suggests that USES= pkgconfig should be added<br> </div> </div> </blockquote> Neah. Upstream's cmake-file tries to use pkgconfig to find libpurple. But it does not work anyway -- and the port supplies definitions for all the of the relevant cmake variables.<br> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div> <div><br> </div> </div> <div>It also fails to build<br> </div> <div> <div><br> </div> </div> <div><a href="https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log" target="_blank" rel="noopener noreferrer" data-ik="ik-secure" moz-do-not-send="true" class="moz-txt-link-freetext">https://pdr2.bofh.network/data/140-diizzy/2024-01-20_15h50m31s/logs/errors/purple-gowhatsapp-1.13.0.log</a><br>; </div> <div> <div><br> </div> </div> </blockquote> <p>So it does... But the failure is not due to anything you mentioned, but because of go's inability to download the additional modules, that the software wants:</p> <blockquote> <pre>go: finding module for package go.mau.fi/whatsmeow/store github.com/hoehermann/purple-gowhatsapp/src/go imports github.com/alfg/mp4: module github.com/alfg/mp4: Get <a class="moz-txt-link-rfc2396E" href="https://proxy.golang.org/github.com/alfg/mp4/@v/list">"https://proxy.golang.org/github.com/alfg/mp4/@v/list"</a>: dial tcp: lookup proxy.golang.org on 199.115.205.169:53: write udp 127.0.0.1:54689->199.115.205.169:53: write: permission denied </pre> </blockquote> <p>Perhaps, that's because downloading during build is a no-no... I did e-mail maintainers of the Uses/go.mk last night seeking suggestions about this. There was no reply, so I decided to commit it -- and asked for help. Which helping would be easier, if the helper(s) could just commit an improvement...<br> </p> <blockquote></blockquote> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div>If you're unsure please consider to create a review / PR instead of just committing.<br> </div> </blockquote> Sorry, but what's the difference? Was Production Support woken up somewhere by a Level-1 alert due to the build-failure?<br> <blockquote type="cite" cite="mid:f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com"> <div>Please back this out for now.</div> </blockquote> <p> The only good reason to back out a change is when it breaks something else. Which this one didn't...</p> <p> I'll try to fix it, of course -- and if someone can help me with predownloading the Go-modules, that'd be great (Maven-using ports must dealing with that somehow...)<br> <br> But why would you want it backed out?!<br> </p> <blockquote> <p>-mi<br> </p> </blockquote> </body> </html> --------------Gn05ibThosslzv8oYJUWh40I--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f74f9837-121e-47ac-819b-27a40d3b4891>