Date: Sun, 7 Sep 1997 14:40:00 +0000 (GMT) From: Terry Lambert <tlambert@primenet.com> To: current@freebsd.org Subject: Bug in committed pci/if_de.c Message-ID: <199709071440.HAA08754@usr09.primenet.com>
next in thread | raw e-mail | index | archive | help
The committed if_de.c incorrectly references FreeBSD version information. This is incorrect, because version information is already encoded in the act of commision to the source tree. One does not check a driver out of -current, and then compile it in an old tree... one checks out the updated driver from the old tag. That's what "stable" is for. It's also incorrect because it's using __FreeBSD__, which is a compiler compile-time constant, and has nothing to do with the version of FreeBSD that is being target by the compile, only (really) which version of FreeBSD the compiler was compiled on. In point of fact, without two "build world"'s, the first build of the tools will take place on the older version of OS (say 2), and have the older number, even when the build world is (supposedly) a newer version (say 3). This is less of a problem for people who track -current, and do so with full world builds, but for people who upgrade via "build world" only at release time, it's an issue. Anyway, since I like to cross-compile and keep a -stable older machine, it's an issue for me. Arguably, there should be no non-contrib code (and that, in user space) that even references __FreeBSD__ at all, and the gcc/cpp values should come from somewhere else. Somewhere configurable, prefferably. Maybe a sysctl that defaults to the real version and can be lowered manually? Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709071440.HAA08754>