Date: Sun, 22 Oct 2017 05:09:58 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Mateusz Guzik <mjg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324789 - in head/sys: kern sys Message-ID: <EF27B86B-8086-4453-9C4D-1DD46945947B@gmail.com> In-Reply-To: <201710200402.v9K42rFP029260@repo.freebsd.org> References: <201710200402.v9K42rFP029260@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Oct 19, 2017, at 21:02, Mateusz Guzik <mjg@FreeBSD.org> wrote: > > Author: mjg > Date: Fri Oct 20 04:02:53 2017 > New Revision: 324789 > URL: https://svnweb.freebsd.org/changeset/base/324789 > > Log: > Mark kdb_active as __read_frequently and switch to bool to eat less space. > > Modified: > head/sys/kern/subr_kdb.c > head/sys/sys/kdb.h > > Modified: head/sys/kern/subr_kdb.c > ============================================================================== > --- head/sys/kern/subr_kdb.c Fri Oct 20 03:38:58 2017 (r324788) > +++ head/sys/kern/subr_kdb.c Fri Oct 20 04:02:53 2017 (r324789) > @@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$"); > #include <machine/smp.h> > #endif > > -int kdb_active = 0; > +bool __read_frequently kdb_active = 0; > static void *kdb_jmpbufp = NULL; > struct kdb_dbbe *kdb_dbbe = NULL; > static struct pcb kdb_pcb; > > Modified: head/sys/sys/kdb.h > ============================================================================== > --- head/sys/sys/kdb.h Fri Oct 20 03:38:58 2017 (r324788) > +++ head/sys/sys/kdb.h Fri Oct 20 04:02:53 2017 (r324789) > @@ -59,7 +59,7 @@ struct kdb_dbbe { > }; \ > DATA_SET(kdb_dbbe_set, name##_dbbe) > > -extern int kdb_active; /* Non-zero while in debugger. */ > +extern bool kdb_active; /* Non-zero while in debugger. */ > extern int debugger_on_panic; /* enter the debugger on panic. */ > extern struct kdb_dbbe *kdb_dbbe; /* Default debugger backend or NULL. */ > extern struct trapframe *kdb_frame; /* Frame to kdb_trap(). */ This broke `kdb_active` use in `kdb_trap`. It’s noticed by gcc on riscv64: https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/4356/console . Please fix or revert. Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE5bk3FaGcY5rvqmb79YOpJmkwhhUFAlnsipYACgkQ9YOpJmkw hhVczA/+I2F111hzAKbMczgzWnSejlmjugNFQb/Ot//CKXgO2qdzNIm3KfQnIU8l WhAZsQQGlUCKSBVkV5uBOBg2i5RrbB23ibnJ0a//CoAXa25V25Bj6juv3hreBoIE IneoXIhHLL7NRnqIEcZg01MynYbvlLm2iuUecj/tMBTLNMO2O4ELPNg0SlOhayLg 1Up3GJQuxpHuKAkLF85NQG99x4pnlDVbgMIikS9flRxtaRWIqIDlyPpFNqqriAdi rXrAu1GvpdGKQtSsJRWlkC3ML1+Ai6lNkkUf3DHrAtlmAwOO0ZwxrK5zqbtUXrZY hHPW42OFCwzMeyNw9V/j9XnLP7s2DckDb6PfrFgc0FmKe8ib0ydp0iw2ta0LVlfo Vrco8mgvLWrKPvJNqDcFhspv41mxftNXzBKUqmG5Hg+kBZXGttzlg7N6s66dABta adWbZAtLEb82zzs860dpmyshZGT3txPj/ewgWcB3qaU4bi/JENEqfM+MW7PI9ace J1dT9JlNsgAdWKlLcRyX8KSOrG4wFpsYxhXGe0/E/iKr5+fZjorKVaEhCsYLbxC3 tpguGl1+g1qtuQuavczibpzOXxaBVaVXC8+RQwBDn+QJDTO8R6EVCi04ZbKgDH5C FJpBDWci++ytilszqx73GhlwWM9pUF1rs1Jt3J7rGbtWk0wHSsY= =WM5Z -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EF27B86B-8086-4453-9C4D-1DD46945947B>