Date: Fri, 22 Nov 2013 15:20:50 +0200 From: Paasiala Kimmo <kpaasial@gmail.com> To: Peter Pentchev <roam@ringlet.net> Cc: FreeBSD Ports <ports@freebsd.org>, Dominic Fandrey <kamikaze@bsdforen.de>, Eitan Adler <lists@eitanadler.com> Subject: Re: DESTDIR support broken? Message-ID: <D9D802A9-D404-4314-8500-89BB7C34E3AA@gmail.com> In-Reply-To: <20131122131727.GB7437@straylight.m.ringlet.net> References: <52850FBA.9010308@bsdforen.de> <CAF6rxgnALxXkxLMdGkOwDwpXArCg4XMUYUEMAzU=dZS-3CGS6Q@mail.gmail.com> <5289CA5E.3010103@bsdforen.de> <CA%2B7WWSc4SRHBg6mqLOV_AHCeqZgoCzHNtqQ2W6%2BLAsSnB8i8hg@mail.gmail.com> <528BA37E.4030308@bsdforen.de> <528F55E4.3040602@bsdforen.de> <20131122131727.GB7437@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On 22.11.2013, at 15.17, Peter Pentchev <roam@ringlet.net> wrote: > On Fri, Nov 22, 2013 at 02:02:28PM +0100, Dominic Fandrey wrote: >> On 19/11/2013 18:44, Dominic Fandrey wrote: >>> On 18/11/2013 20:28, Kimmo Paasiala wrote: >>>> On Mon, Nov 18, 2013 at 10:05 AM, Dominic Fandrey = <kamikaze@bsdforen.de> wrote: >>>>> On 18/11/2013 04:10, Eitan Adler wrote: >>>>>> On Thu, Nov 14, 2013 at 1:00 PM, Dominic Fandrey = <kamikaze@bsdforen.de> wrote: >>>>>>> # make DESTDIR=3D/root/tmpdest install >>>>>>> =3D=3D=3D> Creating some important subdirectories >>>>>>=20 >>>>>> Are you sure you don't mean "make PREFIX=3D/root/tmpdest/" ? >>>>>=20 >>>>> Yes. >>>>>=20 >>>>> -- >>>>=20 >>>> I would expect DESTDIR=3D/some/path just work for any port. Last = commit >>>> to bsd.destdir was over a year ago so either it has been broken for = a >>>> long time or some other more recent commit has broken it. >>>=20 >>> /root/tmpdest is a complete FreeBSD chroot (I did a >>> "make installworld distribution DESTDIR=3D/root/tmpdest" right = beforehand). >>>=20 >>> I tried several ports, they all exhibit the same failure. >>=20 >> The issue is that BSD make (in stable/10) passes "set -e" to the = shell >> by default. >>=20 >> I submitted the details and a fix: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D184170 >=20 > Hmm, even if this is so, I wonder if there would not be another funny > problem later: for ports that actually use staging, bsd.stage.mk tries > to pass a DESTDIR of its own to upstream's build system, so the = DESTDIR > specified on the make(1) command line might not be passed to = upstream's > build system at all. So bsd.destdir.mk might do its thing, but then > bsd.stage.mk would override the DESTDIR setting during the actual = build > and installation of the upstream sources, so I wonder if anything at = all > would be installed into the chroot. >=20 > G'luck, > Peter >=20 As far as I know the temporary setting of DESTDIR to the stagedir is in = effect only during =91make stage=92 so during =91make install=92 your = own custom DESTDIR should be respected. -Kimmo --Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJSj1oyAAoJEFvLZC0FWRVpX8gIALZ0QDBN1IsNTp0zXIkcKWtS df8g6EdqXX74yNB6VhGD6dGG32HyhQrApQpdFBhFt6Ev+spd46NiKu6RW1THCtbz PKMQt9+4i61bpPatix/Qp+X80ZCoqADbHzKoT9H8epMP7ZeOeuCyIeKoEZKHUDFf UcUm5m8KAymoiBQrzzKVaD1Qj/qIFHlShVo6+1qNPZC8YeKsq61Hw7dYu7HXqsj1 hIZmC06hZH7KqUPvR9FTe5NdWgJw/2XXV9wNSCVisVDCGK3G03v1uYKlMUPHu3Md O3wRbRAY6avy6pI1cPhi4i+ZOIHXZjxrvPX3FWQMtW072MTHh3TG6wjJFMgDGkg= =c6Mw -----END PGP SIGNATURE----- --Apple-Mail=_452C4EBC-E8B5-404B-B9D7-2E1687F5AD1D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D9D802A9-D404-4314-8500-89BB7C34E3AA>