Date: Tue, 10 Jun 2014 06:52:12 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Greg Lewis <glewis@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r357248 - in head/games/moria: . files Message-ID: <20140610065212.GC89864@FreeBSD.org> In-Reply-To: <201406100322.s5A3MOVY012329@svn.freebsd.org> References: <201406100322.s5A3MOVY012329@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 10, 2014 at 03:22:24AM +0000, Greg Lewis wrote: > New Revision: 357248 > URL: http://svnweb.freebsd.org/changeset/ports/357248 > QAT: https://qat.redports.org/buildarchive/r357248/ > > +MAKE_ENV+= DOCSDIR="${DOCSDIR}" MKDIR="${MKDIR}" TOUCH="${TOUCH}" \ > + STAGEDIR="${STAGEDIR}" DATADIR="${DATADIR}" What's wrong with default DESTDIR? > -+ ${MKDIR} ${DOCSDIR} > -+ ${BSD_INSTALL_DATA} ${FILES} ${DOCSDIR} > ++ ${MKDIR} ${STAGEDIR}${DOCSDIR} > ++ ${BSD_INSTALL_DATA} ${FILES} ${STAGEDIR}${DOCSDIR} That should be used here instead of STAGEDIR. Not just it would allow you do drop that from MAKE_ENV/ARGS, it would also make it easier to integrate these patches back upstream (DESTDIR is standard name, STAGEDIR is not). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140610065212.GC89864>