Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jun 2018 03:29:07 -0700
From:      Eitan Adler <lists@eitanadler.com>
To:        Eitan Adler <lists@eitanadler.com>, John Baldwin <jhb@freebsd.org>,  FreeBSD Hackers <freebsd-hackers@freebsd.org>
Subject:   Re: gf128_add can be marked as __pure2
Message-ID:  <CAF6rxgkQx5095ouDhXWhi_8i5KARmsS%2BL_Pf56QBES_OkvwyNA@mail.gmail.com>
In-Reply-To: <CAF6rxgnt9eXuLxAa6ZVc7k-CjQYUjfLW4%2B%2BYe%2BQM2giMFwjv8A@mail.gmail.com>
References:  <CAF6rxgn7eEu5WZBH93N4AMHcwCwU3cdhH3rhQunTY%2BCo4PvX4w@mail.gmail.com> <20180317173815.GM75576@funkthat.com> <CAF6rxgnt9eXuLxAa6ZVc7k-CjQYUjfLW4%2B%2BYe%2BQM2giMFwjv8A@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17 March 2018 at 11:38, Eitan Adler <lists@eitanadler.com> wrote:
> On 17 March 2018 at 10:38, John-Mark Gurney <jmg@funkthat.com> wrote:
>> Eitan Adler wrote this message on Mon, Feb 19, 2018 at 19:15 -0800:
>>> Is there any reason not to apply this patch?
>>
>> I don't see why there wouldn't be..
>>
>>> __pure2 means  __attribute__((const)) which is correct in this case as
>>>  gf128_add read no global memory:

For extra clarity, since this is crypto related, can you please accept
here: https://reviews.freebsd.org/D15786


-- 
Eitan Adler



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkQx5095ouDhXWhi_8i5KARmsS%2BL_Pf56QBES_OkvwyNA>