Date: Tue, 1 Aug 2017 10:13:25 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r321849 - in head/tools/tools: bootparttest zfsboottest Message-ID: <96cee950-35c2-3971-defa-be4b5493cfd3@FreeBSD.org> In-Reply-To: <AA2D7845-5DAC-4ABE-8069-F4CEAFBB4534@gmail.com> References: <201708010529.v715Ta2p047371@repo.freebsd.org> <f27860f2-9835-8bbb-7066-d36f45917e36@FreeBSD.org> <AA2D7845-5DAC-4ABE-8069-F4CEAFBB4534@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/08/2017 09:51, Ngie Cooper (yaneurabeya) wrote: > >> On Jul 31, 2017, at 23:39, Andriy Gapon <avg@FreeBSD.org> wrote: >> >> On 01/08/2017 08:29, Ngie Cooper wrote: >>> Author: ngie >>> Date: Tue Aug 1 05:29:36 2017 >>> New Revision: 321849 >>> URL: https://svnweb.freebsd.org/changeset/base/321849 >>> >>> Log: >>> Fix the return type for pager_output(..) in bootparttest and zfsboottest >>> >>> pager_output(..) has always returned int. For some reason (probably the >>> clang 5.0 update), this mismatch now results in an error with CC=clang. >>> >>> MFC after: 1 week >> >> I am not sure if this a correct fix... >> Return value of pager_output() signifies whether to continue printing, return >> value of printf is a number of characters printed. > > You’re right — it was wrong. Fixed in r321852. Thank you! The next problem you are going to encounter would be missing ldi_get_size(). I have some WIP for that if you are interested. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96cee950-35c2-3971-defa-be4b5493cfd3>