Date: Sun, 11 Feb 2007 11:53:17 +0300 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Ceri Davies <ceri@submonkey.net> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/rc.d hostname Message-ID: <20070211085317.GF13808@comp.chem.msu.su> In-Reply-To: <20070210205228.GE9455@submonkey.net> References: <200702101313.l1ADDX8m056868@repoman.freebsd.org> <20070210205228.GE9455@submonkey.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 10, 2007 at 08:52:28PM +0000, Ceri Davies wrote:
> On Sat, Feb 10, 2007 at 01:13:33PM +0000, Yar Tikhiy wrote:
> > yar 2007-02-10 13:13:33 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > etc/rc.d hostname
> > Log:
> > Handle the case when the admin forgot to set $hostname,
> > which can happen in new installations: advise to set the
> > variable and refer to rc.conf(5).
>
> Isn't it possible for the hostname to come via DHCP? How does this
> behave in that case (or rather, I can see how it behaves; is that the
> right thing)?
I've never played with setting the hostname via DHCP. In my change,
I just tried not to break the existing code related to DHCP. Perhaps
someone using DHCP to get the hostname could shed light on the topic.
> > | @@ -58,7 +58,16 @@ hostname_start()
> > | fi
> > | fi
> > |
> > | - /bin/hostname ${hostname}
> > | + # Have we got a hostname yet?
> > | + #
> > | + if [ -z "${hostname}" ]; then
> > | + warn "\$hostname is not set -- see ${rcvar_manpage}."
> > | + return
> > | + fi
> > | +
> > | + # All right, it is safe to invoke hostname(1) now.
> > | + #
> > | + /bin/hostname "${hostname}"
> > | echo "Setting hostname: `hostname`."
>
> Are the backticks necessary here? Why don't we use ${hostname}?
Thus we determine what name has actually been set. Our doing so
reeks of paranoia, of course. :-) Perhaps a better ordering would
be:
echo "Setting hostname: ${hostname}."
/bin/hostname "${hostname}"
So possible error messages will follow the introductory statement,
which makes more sense. Any objecttions?
--
Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070211085317.GF13808>