Date: Tue, 24 Jun 2003 18:53:51 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Julian Elischer <julian@FreeBSD.org>, Maksim Yevmenkin <m_evmenkin@yahoo.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin Makefile src/usr.sbin Makefile Message-ID: <20030624155351.GB6651@sunbay.com> In-Reply-To: <200306241325.h5ODPO3i075295@repoman.freebsd.org> References: <200306241325.h5ODPO3i075295@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--R3G7APHDIzY6R/pk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jun 24, 2003 at 06:25:24AM -0700, Julian Elischer wrote:
> julian 2003/06/24 06:25:24 PDT
>=20
> FreeBSD src repository
>=20
> Modified files:
> usr.bin Makefile=20
> usr.sbin Makefile=20
> Log:
> Connect bluetooth tools for i386 only.
> These are probably machine independent, but
> there is no way for the developers to test them other than on x86.
> =20
> They will become MD as testing becomes possible.
> =20
> Revision Changes Path
> 1.241 +2 -0 src/usr.bin/Makefile
> 1.258 +2 -0 src/usr.sbin/Makefile
>=20
Please back this out. The makefiles underneath that are not ready
to be connected to the source tree; I've sent you and Maksim the
patch that cleans this up (before the latest import), but I never
heard back any feedback. Here's one example where this creates a
problem:
: # $Id: Makefile,v 1.3 2003/03/24 23:59:49 max Exp $
$Id$'s on makefiles are bogus, and especially that Maksim agreed
developing against FreeBSD repository.
: # $FreeBSD: src/usr.bin/bluetooth/btsockstat/Makefile,v 1.2 2003/05/10 21=
:44:42 julian Exp $
:=20
: PROG=3D btsockstat
: BINGRP=3D kmem
: BINMODE=3D 2555
: MAN1=3D btsockstat.1
:=20
MAN1 is spelled MAN nowadays.
: DESTDIR=3D /usr/bin/
: MANDIR=3D ../share/man/man
:=20
These two are a real problem.
: WARNS?=3D 2
: CFLAGS+=3D -g -I${.CURDIR}/../../../sys/netgraph/bluetooth/include/
:=20
-g should not be in CFLAGS. -I to access bluetooth includes are bogus,
and you also have the patch for that.
: SRCS=3D btsockstat.c
: DPADD=3D ${LIBKVM}
: LDADD=3D -lkvm=20
:=20
: .include <bsd.prog.mk>
Cheers,
--=20
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
--R3G7APHDIzY6R/pk
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE++HQPUkv4P6juNwoRAmh/AJkBkt6hMz8pUvLdVu9YcgEwbGjwHACcDRyR
YRrDdEIRDtjTMnKCdgjivA8=
=jO30
-----END PGP SIGNATURE-----
--R3G7APHDIzY6R/pk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030624155351.GB6651>