Date: Wed, 20 Jun 2001 12:48:37 -0700 (PDT) From: Bosko Milekic <bmilekic@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vx if_vx.c src/sys/kern uipc_mbuf.c src/sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c if_vr.c if_wb.c Message-ID: <200106201948.f5KJmbG47979@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
bmilekic 2001/06/20 12:48:37 PDT
Modified files:
sys/dev/lge if_lge.c
sys/dev/nge if_nge.c
sys/dev/vx if_vx.c
sys/kern uipc_mbuf.c
sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c
if_vr.c if_wb.c
Log:
Change m_devget()'s outdated and unused `offset' argument to actually mean
something: offset into the first mbuf of the target chain before copying
the source data over.
Make drivers using m_devget() with a first argument "data - ETHER_ALIGN"
to use the offset argument to pass ETHER_ALIGN in. The way it was previously
done is potentially dangerous if the source data was at the top of a page
and the offset caused the previous page to be copied (if the
previous page has not yet been appropriately mapped).
The old `offset' argument in m_devget() is not used anywhere (it's always
0) and dates back to ~1995 (and earlier?) when support for ethernet trailers
existed. With that support gone, it was merely collecting dust.
Tested on alpha by: jlemon
Partially submitted by: jlemon
Reviewed by: jlemon
MFC after: 3 weeks
Revision Changes Path
1.6 +4 -5 src/sys/dev/lge/if_lge.c
1.14 +4 -5 src/sys/dev/nge/if_nge.c
1.33 +2 -5 src/sys/dev/vx/if_vx.c
1.85 +26 -31 src/sys/kern/uipc_mbuf.c
1.52 +4 -5 src/sys/pci/if_dc.c
1.59 +9 -22 src/sys/pci/if_rl.c
1.35 +4 -5 src/sys/pci/if_sf.c
1.33 +4 -5 src/sys/pci/if_sis.c
1.43 +4 -5 src/sys/pci/if_sk.c
1.44 +4 -5 src/sys/pci/if_vr.c
1.42 +4 -5 src/sys/pci/if_wb.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200106201948.f5KJmbG47979>