Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Jan 2017 09:29:04 +0000
From:      Steven Hartland <killing@multiplay.co.uk>
To:        freebsd-hackers@freebsd.org
Subject:   Re: [PATCH] Fix "netstat -rs"
Message-ID:  <73839dec-b03d-cdae-a0b4-1e1e6453215f@multiplay.co.uk>
In-Reply-To: <1483953391-11045-1-git-send-email-sebastian.huber@embedded-brains.de>
References:  <1483953391-11045-1-git-send-email-sebastian.huber@embedded-brains.de>

next in thread | previous in thread | raw e-mail | index | archive | help
Thanks Sebastian I've just committed this.

On 09/01/2017 09:16, Sebastian Huber wrote:
> Load KVM symbols early so that for example rt_stats() can use them,
> otherwise we get:
>
> $ netstat -rs
> rtstat: symbol not in namelist
> ---
>   usr.bin/netstat/main.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/usr.bin/netstat/main.c b/usr.bin/netstat/main.c
> index 4e4428d..f26bf57 100644
> --- a/usr.bin/netstat/main.c
> +++ b/usr.bin/netstat/main.c
> @@ -427,6 +427,9 @@ main(int argc, char *argv[])
>   	if (xflag && Tflag)
>   		xo_errx(1, "-x and -T are incompatible, pick one.");
>   
> +	/* Load all necessary kvm symbols */
> +	kresolve_list(nl);
> +
>   	if (Bflag) {
>   		if (!live)
>   			usage();
> @@ -507,9 +510,6 @@ main(int argc, char *argv[])
>   		exit(0);
>   	}
>   
> -	/* Load all necessary kvm symbols */
> -	kresolve_list(nl);
> -
>   	if (tp) {
>   		xo_open_container("statistics");
>   		printproto(tp, tp->pr_name, &first);




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73839dec-b03d-cdae-a0b4-1e1e6453215f>