Date: Mon, 13 Sep 2004 22:21:14 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: current@freebsd.org Subject: Re2: Possible bug in softclock() Message-ID: <200409140521.i8E5LEJv001720@apollo.backplane.com>
next in thread | raw e-mail | index | archive | help
oops... no , forget... it's correct. I got the sense reversed. -Matt Matthew Dillon <dillon@backplane.com> : : In softclock(), should this line: : : c->c_flags = (c->c_flags & ~CALLOUT_PENDING); : : be: : : c->c_flags = (c->c_flags & ~(CALLOUT_PENDING | CALLOUT_MPSAFE)); : : ? : : Otherwise routines which call callout_reset() to reset the callout : will always clear the CALLOUT_MPSAFE flag. This won't hurt things, : but it will make them more inefficient.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409140521.i8E5LEJv001720>