Date: Fri, 9 Jul 2010 12:02:30 +0200 From: Anton Berezin <tobez@tobez.org> To: Denis Shaposhnikov <dsh@vlink.ru> Cc: cvs-ports@FreeBSD.org, Yen-Ming Lee <leeym@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/p5-Params-Validate Makefile Message-ID: <20100709100230.GA99812@heechee.tobez.org> In-Reply-To: <201006180034.o5I0YVRR012560@repoman.freebsd.org> References: <201006180034.o5I0YVRR012560@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Denis,
I don't understand why you approved this PR. Three days before
this commit I had a conversation with you with regard to this port missing a
dependency on ExtUtils::CBuilder. You provided a diff with a fix,
which I immediately committed with minor modifications.
Then, three days later, you approve a PR which removes CBuilder dependency
which has just got it.
So now the port does not work again. :-/
Could we somehow avoid such flip-flops in the future? Maybe better testing
is in order? Just a thought.
Cheers,
\Anton.
===> Configuring for p5-Params-Validate-0.95_2
Warning: ExtUtils::CBuilder not installed or no compiler detected
Proceeding with configuration, but compilation may fail during Build
Checking prerequisites...
build_requires:
! ExtUtils::CBuilder is not installed
ERRORS/WARNINGS FOUND IN PREREQUISITES. You may wish to install the
versions
of the modules indicated above before proceeding with this installation
Run 'Build installdeps' to install missing prerequisites.
Creating new 'MYMETA.yml' with configuration results
Creating new 'Build' script for 'Params-Validate' version '0.95'
===> Building for p5-Params-Validate-0.95_2
Building Params-Validate
Error: no compiler detected to compile 'lib/Params/Validate.c'. Aborting
*** Error code 2
On Fri, Jun 18, 2010 at 12:34:31AM +0000, Yen-Ming Lee wrote:
> leeym 2010-06-18 00:34:31 UTC
>
> FreeBSD ports repository
>
> Modified files:
> devel/p5-Params-Validate Makefile
> Log:
> - simplify dependency
> - bump PORTREVISION
>
> PR: ports/147954
> Submitted by: leeym
> Approved by: maintainer
>
> Revision Changes Path
> 1.42 +9 -6 ports/devel/p5-Params-Validate/Makefile
>
>
>
> cvsweb links:
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/devel/p5-Params-Validate/Makefile
--
Our society can survive even a large amount of irrational regulation.
-- John McCarthy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100709100230.GA99812>