Date: Mon, 30 Apr 2018 09:35:20 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Eitan Adler <lists@eitanadler.com>, Jan Beich <jbeich@freebsd.org>, Bernard Spil <brnrd@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468626 - head/security/libressl Message-ID: <20180430073520.4lerfledm5e35eiz@atuin.in.mat.cc> In-Reply-To: <20180429175337.GK72744@graf.pompo.net> References: <201804291237.w3TCbbjB046542@repo.freebsd.org> <4lju-t6cm-wny@FreeBSD.org> <CAF6rxgn8SOKrU2YmkMbBT7Eq3qvrFiNLyQ4e=NOh6aKPhhsrrA@mail.gmail.com> <20180429175337.GK72744@graf.pompo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--vsyaqisw5bvvjtgz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 29, 2018 at 05:53:37PM +0000, Thierry Thomas wrote: > Le dim. 29 avr. 18 =E0 19:36:51 +0200, Eitan Adler <lists@eitanadler.com> > =E9crivait=A0: >=20 > > >> security/libressl: Force linking libthr > > >> > > >> - Fixes problems with loading private ssh keys > > > [...] > > >> +LDFLAGS+=3D -lthr > > > > > > Better use -lpthread in case user have different POSIX threads implem= entation. > > > Probably only affects downstream as FreeBSD dropped libkse, libc_r ye= ars ago. > >=20 > > Further nit: -pthread not -lpthread. The primary difference is some > > preprocessor flags such as _REENTRANT and __USE_REENTRANT 1. >=20 > We used to have a PTHREAD_LIBS variable (along with PTHREAD_CFLAGS); why > did they disappear? Because for about a decade, they only contained -pthread (and nothing), so keeping them was deemed useless. --=20 Mathieu Arnold --vsyaqisw5bvvjtgz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJa5sc4XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IMe8P/iXpvO84ZvhYwBGObNqoIHB+ oQFl14XFA7GZvLBraaHVv9i+VD4/g2/wblNKopXi4NXEPpZhqwDe0P4Dm4Fm5Klb BhqLVnXVE2ANiWVHEOn+ryJBIDSmPI0rCvU6tlztlfCyitmYVpxAyYu3dWfVCUrN lp/yuEezkL5k3ul7JVulNUvaUlSg65r8Bs0sza9Zf8Mv5oQI+L5rtSduRW469o+4 cf5PJspTRfvqB3XP+dHTapsmnZM4GdILNR/r2dnCDb0ahaELG2RWS1K/trFT15bE vrnLkGTL4tq5l28sIb5Ec569IGDQPRmM98jXy6PihsQfzj7yLSD8Ii/3NW5mvite mlFyEXUH7sxfCSEY0fpB1FgucVrlhPHjY/belKKuMWeH5QNHc0cq0ZwSdGJfcdsF XelIzt1lPkTdSjp6moo4kTjyQzwa6Nhy5OT4c7k4UAUSAS3OBuVVS3b7ZUvJ5bIZ yvdshbd4XyWdqsPFk6BquFAvWUK7W/zrnnAR4sXdiUafIneY/QUwVy5XtFvoO11d gB6eslo3cenjTXpaHrKtirshvzRWj/ZMCMeFxuP7depbA6sV+PYHe05mjiCZggX+ Dpmx2qiHocOOJ7H3B7DWacd9iwCw7GnFputabE4aNwxKxeSXQ+iKmR8yf3EKNibx 7x2hqf5kuZ2n9h88yH+/ =5N/Y -----END PGP SIGNATURE----- --vsyaqisw5bvvjtgz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180430073520.4lerfledm5e35eiz>