Date: Sat, 15 Nov 2014 21:22:27 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Alfred Perlstein <alfred@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread Message-ID: <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com> In-Reply-To: <546833FE.9060904@freebsd.org> References: <201411160508.sAG58JdG055637@svn.freebsd.org> <546833FE.9060904@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Nov 15, 2014, at 21:19, Alfred Perlstein <alfred@freebsd.org> wrote: > This looks easy enough to fix under _thr_find_thread() in libthread. > > Any interest in fixing it? Yes, if it’s POSIXly correct and doesn’t break everything else. > Might be worth hacking _thr_find_thread() to take an ERRNO to return based on NULL until we chase down all the paths into it just in case EINVAL is a valid ptr. K. Thanks for the hint! > Also, just wondering what happens on other platforms, does it elicit a crash? Ie. is NULL a safe value to pass in on other platforms? I wish I knew what happened on !x86 platforms… I honestly don’t have access to ARM/MIPS/PowerPC, so I can’t say :/. Thanks! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUaDSTAAoJEMZr5QU6S73endAH+waK3sgNyS3a1P63IL8QHLN9 JJJDeHhZTN3NiJDca+ulsudhSvfgy01Ms505Zm82QqUZcet4bz6c94gX0udyNu14 CfE6c1fV2jEt1Az2n7fPBR9ILY8fJMz+XaPyzut2V5JFzwW5bnuH8WJuWkk/MVR/ nGRXkhSQPVpnD45NnWSWyXkBecpObhCpTZc/Lrp0K6hmH7jjlOT6I08MEzUp0qkY 1ULZYUqh/8KYOHGNFYak2dEx5fVWC/QYWSRR9ltZsl2epocbDhP8e9jeEC02UvfD 2F+98HVHIkB1IX1drgYiM7xab0o5ErtdVhXk4CFXzFiN6BkhT9vxnPGlasHvU14= =6TSV -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45B1482F-352E-4874-8A89-1EC225A32E93>