Date: Wed, 25 Dec 2013 17:51:14 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common Message-ID: <CAJ-Vmo=FufoALvqW-y9iXk%2BfHXDzNcd1riXX5%2Bg_1kG-Kus1=w@mail.gmail.com> In-Reply-To: <201312252245.rBPMjX5J046556@svn.freebsd.org> References: <201312252245.rBPMjX5J046556@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Dim, I'd prefer you didn't remove unused code in drivers like this. If you must, #if 0 them out. Future people hacking on the driver may find it nice to have as much code in there which talks to the hardware. It may not be currently called, but it's at least there. Thanks, -adrian On 25 December 2013 14:45, Dimitry Andric <dim@freebsd.org> wrote: > Author: dim > Date: Wed Dec 25 22:45:33 2013 > New Revision: 259896 > URL: http://svnweb.freebsd.org/changeset/base/259896 > > Log: > In sys/dev/cxgb/common/cxgb_mc5.c, remove static function > dbgi_wr_addr3(), which is unused since r167514. > > MFC after: 3 days > > Modified: > head/sys/dev/cxgb/common/cxgb_mc5.c > > Modified: head/sys/dev/cxgb/common/cxgb_mc5.c > ============================================================================== > --- head/sys/dev/cxgb/common/cxgb_mc5.c Wed Dec 25 22:36:27 2013 (r259895) > +++ head/sys/dev/cxgb/common/cxgb_mc5.c Wed Dec 25 22:45:33 2013 (r259896) > @@ -98,13 +98,6 @@ static int mc5_cmd_write(adapter_t *adap > F_DBGIRSPVALID, 1, MAX_WRITE_ATTEMPTS, 1); > } > > -static inline void dbgi_wr_addr3(adapter_t *adapter, u32 v1, u32 v2, u32 v3) > -{ > - t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR0, v1); > - t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR1, v2); > - t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_ADDR2, v3); > -} > - > static inline void dbgi_wr_data3(adapter_t *adapter, u32 v1, u32 v2, u32 v3) > { > t3_write_reg(adapter, A_MC5_DB_DBGI_REQ_DATA0, v1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=FufoALvqW-y9iXk%2BfHXDzNcd1riXX5%2Bg_1kG-Kus1=w>