Date: Sat, 24 Oct 2009 15:19:50 +0400 From: Stanislav Sedov <stas@deglitch.com> To: Beat Gaetzi <beat@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/emulators/virtualbox Makefile ports/emulators/virtualbox/files patch-configure Message-ID: <20091024151950.759c5090.stas@deglitch.com> In-Reply-To: <4AE2DF85.1090007@FreeBSD.org> References: <200910231429.n9NEToUC016266@repoman.freebsd.org> <20091024143852.9be13dbe.stas@deglitch.com> <4AE2DF85.1090007@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, 24 Oct 2009 13:05:41 +0200
Beat Gaetzi <beat@FreeBSD.org> mentioned:
> Stanislav Sedov wrote:
> > On Fri, 23 Oct 2009 14:29:50 +0000 (UTC)
> > Beat Gaetzi <beat@FreeBSD.org> mentioned:
> > \
> >> | #
> >> |
> >> | PORTNAME= virtualbox
> >> | @@ -76,6 +76,14 @@ KMK_BUILDTYPE= release
> >> | KMK_CONFIG= VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys
> >> | KMK_FLAGS=
> >> |
> >> | +.if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS)
> >> | +BROKEN= NLS support requires QT4 frontend. Run 'make config' again!
> >> | +.endif
> >> | +
> >> | +.if defined(WITHOUT_X11) && !defined(WITHOUT_QT4)
> >> | +BROKEN= QT4 frontend requires X11 support. Run 'make config' again!
> >> | +.endif
> >> | +
> >
> > Why not enforce these required options instead?
>
> Lets assume a user want to install virtualbox headless on a server. He
> deselect X11 and QT4 support but accidentally select NLS support. If we
> enfore the required options this means we will install all the X11 and
> QT4 dependencies without asking on his server. With the current checks
> the user could decide if he wants to deselect NLS support or add QT4 and
> X11 support.
>
There's also a possibility to disable NLS in WITHOUT_X11 case as well.
My point it that on the servers one usually have WITHOUT_X11 defined in
/etc/make.conf and build ports in batch mode. As virtualbox has NLS
enabled by default this commit made default configuration broken for
WITHOUT_X11 case. You can just give the user a warning about disabling
NLS if it conflicts with the configuration selected and go ahead.
--
Stanislav Sedov
ST4096-RIPE
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIcBAEBAgAGBQJK4uLaAAoJEKN82nOYvCd0444P/iRUtAJDKV2n5I7LkOYORF76
25DQ2m6KozPgu1E7zDHcyEsUM248ZOtRzHEpQ+//Qoa/qUjLOGXaFLTowhAj+7EV
kjIc/xG2LLZBcLoSJ7OouNUzNnIQfwDWUHB7KKDRPUq7qC/oGxX16khSBBh44guM
L41eYOnn2vNkFI7h2MEI/n9mpPlvAmv/uuhNdCck8mcNx+JdOgp6Zsm48+NkgdPF
OippgT9ExXfiwslCAUATxFe92A+aqqrUWyC296e5ai2A40quUbXYdKPGidnd2tMm
VZ7Zwwbw8O5qVe7Hc173yIuX+ZYrUooP3CqNLzp3ow9CT+XVvx8+j0RKLVNmiVOm
LIdE60JcshlsFzLjzzrikLp4F8J3ki6EGyQj/NBbQSHJ5QfJ42E86giGNcMHaufs
GdXLDsbu4ChKkkK6MqH5PlwJf85aNBnfv68wzttDiW0I5bv77kSQ600nW5wI63fe
gZws9Xil9dmxw3ZbrFyJxTXsCY9DfHg0dhmPut0vUprSkdEU4ieNVZQfrsm7Hd9S
Po3hqeohDcnZHIxcLY6u6yQutWSYCriibsb7NcwZiDrDqi85HqozS0ixEKVO7XR7
ih26i/srsRoRukrFHvl+9L9nrkSCKtxfjMTyKtLg0aac3h+7PnMoo2HkeFur5FiT
m5Wcks40LGO7uVi5oLR0
=Wtsn
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091024151950.759c5090.stas>