Date: Thu, 09 Mar 2006 09:38:25 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: ru@FreeBSD.ORG Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/share/mk bsd.README Message-ID: <20060309.093825.112623724.imp@bsdimp.com> In-Reply-To: <20060309090307.GK54826@ip.net.ua> References: <200603090133.k291XcfB005631@repoman.freebsd.org> <20060309090307.GK54826@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20060309090307.GK54826@ip.net.ua> Ruslan Ermilov <ru@FreeBSD.org> writes: : On Thu, Mar 09, 2006 at 01:33:38AM +0000, Warner Losh wrote: : > imp 2006-03-09 01:33:38 UTC : > : > FreeBSD src repository : > : > Modified files: : > share/mk bsd.README : > Log: : > Now that we now spell NO_MAN=xxx MAN=, update the docs. : > : > Submitted by: John Hein : > : > Revision Changes Path : > 1.30 +1 -1 src/share/mk/bsd.README : > : I object. : : 1) This is not common: : : grep '^NO_MAN=' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l : 10 : grep '^MAN=[[:space:]]*(#.*)?$' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l : 0 : : 2) MAN= is worse for performance (with NO_MAN, bsd.man.mk is not : processes at all which is faster). : : 3) This is in contrast with NO_OBJ and similar knobs. : : I can only suggest to make it spell "NO_MAN=", i.e., without any value. : : Was there some discussion that I've missed? Sorry, I thought this was the consensus and direction people wanted to move. I've reverted. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060309.093825.112623724.imp>