Date: Wed, 24 Jan 2001 10:32:38 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Jeremy Lea <reg@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add extract.c main.c src/usr.sbin/pkg_install/create create.h main.c perform.c pkg_create.1 src/usr.sbin/pkg_install/lib file.c plist.c Message-ID: <3A6E9326.51CA5EC0@FreeBSD.org> References: <200101221201.f0MC1tV27540@freefall.freebsd.org> <20010124000617.C63549@shale.csir.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
Jeremy Lea wrote: > Hi, > > On Mon, Jan 22, 2001 at 04:01:55AM -0800, Maxim Sobolev wrote: > > Modified files: > > usr.sbin/pkg_install/add extract.c main.c > > usr.sbin/pkg_install/create create.h main.c perform.c > > pkg_create.1 > > usr.sbin/pkg_install/lib file.c plist.c > > Log: > > - Add ability to handle bzip2-compressed packages; > > The code in create/main.c never turns UseBzip2 = TRUE. Which implies > it was never tested, which also implies that the command line switch is > redundant. Oh, you are right, I'm sorry. I supposed that I fixed it in all my working copies. And no, I tested how it works. > We can guess bzip2 compression from the suffix. In fact we > have to have a bzip2 suffix, else we can't guess how to extract it, so > having a command line switch can only cause bad things to happen. Not actually, if you are specifying package name witout trailing suffix pkg_create will automatically add .tgz by default or .tbz2 if -y is specified. See pkg_perform() finction for details. > > No response from: -ports > > This should have read > > Approved by: jkh > > He is the maintainer of this code, not -ports. (Even if he never > changes it or reviews patches :-( ) I CC'ed him as well, but did not hear anything back. Thanks for taking a look at my changes. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A6E9326.51CA5EC0>