Date: Mon, 5 Feb 2007 15:52:44 +0300 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Bruce M Simpson <bms@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_tap.c Message-ID: <20070205125244.GO35552@codelabs.ru> In-Reply-To: <20070205124332.GG1621@FreeBSD.org> References: <200702030257.l132vkfT089439@repoman.freebsd.org> <20070205124332.GG1621@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> btw, we have a strange situation with handling off non-broadcast > frames not destined to us in general. > > In a case, when we have generic Ethernet in promisc, and received foreign > packets (on a hub, or a buggy switch), they are forwarded to ether_demux() > and to upper layers respectively. Isn't this incorrect? > > Moreover, in case of promisc + net.inet.ip.forwarding=1 our box will resend > all the received foreign packets :( > > What do you think about checking that (ether_dhost == ours || BCAST || MCAST) > before sending packet to ether_demux? If you will do so, please, do not forget to check if we're doing bridging, because your proposal will break it. If I understand the things correctly ;)) -- Eygene
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070205125244.GO35552>