Date: Sun, 28 Feb 2016 15:37:24 +0300 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: Brooks Davis <brooks@freebsd.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: Re: svn commit: r296146 - stable/9/sys/dev/filemon Message-ID: <20160228123724.GC11654@zxy.spb.ru> In-Reply-To: <20160228122008.GA27425@spindle.one-eyed-alien.net> References: <201602272057.u1RKvYfF035338@repo.freebsd.org> <20160228102728.GA94639@zxy.spb.ru> <20160228122008.GA27425@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 28, 2016 at 12:20:09PM +0000, Brooks Davis wrote: > On Sun, Feb 28, 2016 at 01:27:28PM +0300, Slawa Olhovchenkov wrote: > > On Sat, Feb 27, 2016 at 08:57:34PM +0000, Bryan Drewery wrote: > > > > > Author: bdrewery > > > Date: Sat Feb 27 20:57:34 2016 > > > New Revision: 296146 > > > URL: https://svnweb.freebsd.org/changeset/base/296146 > > > > > > Log: > > > MFC r242088: > > > > > > Desupport pre-FreeBSD 7.1. > > > > > > Modified: > > > stable/9/sys/dev/filemon/filemon.c > > > Directory Properties: > > > stable/9/sys/ (props changed) > > > stable/9/sys/dev/ (props changed) > > > -#if __FreeBSD_version < 701000 > > > > Not specialy to this commit, just for information: what purpose to > > have in src tree, already divided to branches, pieces of code under > > #if? > > > > Of couse, question not about external maintained code. > > Filemon started as externally maintained code and initially it was > a bit ambiguous which direction changes would flow. I.e. historical behaviour. > Sometimes it's also useful to allow code in HEAD to just work when > copied to stable so people can see if their problem is fixed without > having to merge too much. Please, check me: in mostly cases this is equivalent of MFC in one commit (and have same complexity as MFC) but w/o actualy MFC. > In general though, we should remove code like > this in things maintained entirely in tree. Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160228123724.GC11654>