Date: Mon, 5 Nov 2018 15:02:58 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alex Richardson <arichardson@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338268 - head Message-ID: <a7768d1a-a59f-6a82-7085-48e8d62db1f9@FreeBSD.org> In-Reply-To: <201808231819.w7NIJAq5071940@repo.freebsd.org> References: <201808231819.w7NIJAq5071940@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --caoOR4wLovCOd87Yn5mrKAyTOgkKrVOgn Content-Type: multipart/mixed; boundary="t4jvYhXgQulKPLPgIe0Bij5G1TH8XAaW2"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alex Richardson <arichardson@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <a7768d1a-a59f-6a82-7085-48e8d62db1f9@FreeBSD.org> Subject: Re: svn commit: r338268 - head References: <201808231819.w7NIJAq5071940@repo.freebsd.org> In-Reply-To: <201808231819.w7NIJAq5071940@repo.freebsd.org> --t4jvYhXgQulKPLPgIe0Bij5G1TH8XAaW2 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/23/2018 11:19 AM, Alex Richardson wrote: > Author: arichardson > Date: Thu Aug 23 18:19:10 2018 > New Revision: 338268 > URL: https://svnweb.freebsd.org/changeset/base/338268 >=20 > Log: > Fix non-FreeBSD host lib32 build for TARGET=3Damd64 > =20 > When building on non-FreeBSD systems we need to pass an explicit targ= et > triple to clang otherwise it will attempt to build with the host trip= le. > This also has advantages when building on a FreeBSD host: we now tell= > clang that we are targeting at least FreeBSD 12.0 instead of an older= > version so it can enable newer features. > =20 > Reviewed By: brooks (mentor) > Approved By: jhb (mentor) > Differential Revision: https://reviews.freebsd.org/D16842 >=20 > Modified: > head/Makefile.libcompat >=20 > Modified: head/Makefile.libcompat > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Makefile.libcompat Thu Aug 23 18:19:01 2018 (r338267) > +++ head/Makefile.libcompat Thu Aug 23 18:19:10 2018 (r338268) > @@ -14,6 +14,11 @@ LIB32CPUFLAGS=3D -march=3Di686 -mmmx -msse -msse2 > .else > LIB32CPUFLAGS=3D -march=3D${TARGET_CPUTYPE} > .endif > +.if ${WANT_COMPILER_TYPE} =3D=3D gcc || \ > + (defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} =3D=3D gcc) > +.else > +LIB32CPUFLAGS+=3D -target x86_64-unknown-freebsd12.0 This can be ${TARGET_TRIPLE}, no? It also seems like it should be in the LIBSOFT flags too; via LIBCOMPATCFLAGS. > +.endif > LIB32CPUFLAGS+=3D -m32 > LIB32WMAKEENV=3D MACHINE=3Di386 MACHINE_ARCH=3Di386 \ > MACHINE_CPU=3D"i686 mmx sse sse2" >=20 --=20 Regards, Bryan Drewery --t4jvYhXgQulKPLPgIe0Bij5G1TH8XAaW2-- --caoOR4wLovCOd87Yn5mrKAyTOgkKrVOgn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAlvgzCNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G l8/VyggAy7z51q/IhG2qV628pNnNQGvcvi08JXgL2tUL99q2QpH47Xt6dg85kR6B eVY2RvsBlXs8XVf6WPvAzYTZgEoECvU4GWVgy15vcpzBPfY2hERKQb6Go1L7Rmvn idgkFPDXpnc7hvrJShE2SsFKtKG+wk3SUV6yxbWfFn4rW4nD7xudm1VKqy+2Hqe2 vuXs7DrwiYzgEgi7Cy26kj/RGIAiCF51AGfAc0xqFtv5//o0rEbWdCnYRph+urkR 7fDZ2X1siutiYyzjmv1AU6wej+DcY2FteRHoUpznFjE9Geq4miKn6WyVtVdUzQrt So/adKc5VegmO3JskzKQZ2pwRooMzw== =sMbA -----END PGP SIGNATURE----- --caoOR4wLovCOd87Yn5mrKAyTOgkKrVOgn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a7768d1a-a59f-6a82-7085-48e8d62db1f9>