Date: Tue, 10 Jun 2008 18:41:21 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Cy Schubert <cy@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/comms/conserver Makefile ports/comms/conserver/files conserver.sh Message-ID: <484F2D41.2010005@FreeBSD.org> In-Reply-To: <200806101928.m5AJS6Pc038673@repoman.freebsd.org> References: <200806101928.m5AJS6Pc038673@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------010108000606070408080901 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cy Schubert wrote: > cy 2008-06-10 19:28:06 UTC > > FreeBSD ports repository > > Modified files: > comms/conserver Makefile > comms/conserver/files conserver.sh > Log: > Implmement rcNG. > > Revision Changes Path > 1.30 +1 -1 ports/comms/conserver/Makefile > 1.5 +28 -17 ports/comms/conserver/files/conserver.sh > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver/Makefile.diff?&r1=1.29&r2=1.30&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver/files/conserver.sh.diff?&r1=1.4&r2=1.5&f=h Thanks for doing this! I have a few comments. First a minor one, it's rc.d now, since it's not "next generation" anymore. :) You'll probably also want to take a look at http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for a more detailed explanation of these concepts. 1. You need 'USE_RC_SUBR= conserver' in the Makefile. 2. You'll want to nuke the bit about conserver.sh at the end of post-install in the Makefile and in the pkg-plist. (No need to add anything to the pkg-plist, USE_RC_SUBR takes care of that for you.) 3. You should rename conserver.sh to conserver.in. Don't worry about doing a repo copy for this, it is a nice to have but we haven't bothered for this issue. 4. I'm not sure why you included 'BEFORE: LOGIN'. If setting up the user identities requires something in the port (which it does not appear to) then 'REQUIRE: LOGIN' is preferred. 5. The script itself can be simplified quite a bit by relying on rc.subr. I've attached a version that works for me (although admittedly lightly tested) and patches to the Makefile and plist. hth, Doug -- This .signature sanitized for your protection --------------010108000606070408080901 Content-Type: text/plain; name="conserver.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="conserver.diff" SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC91c3IvbG9jYWwvbmN2 cy9wb3J0cy9jb21tcy9jb25zZXJ2ZXIvTWFrZWZpbGUsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuMzAKZGlmZiAtdSAtcjEuMzAgTWFrZWZpbGUKLS0tIE1ha2VmaWxlCTEwIEp1biAyMDA4 IDE5OjI4OjA2IC0wMDAwCTEuMzAKKysrIE1ha2VmaWxlCTExIEp1biAyMDA4IDAxOjI2OjU3 IC0wMDAwCkBAIC0yMSw2ICsyMSw4IEBACiBCVUlMRF9ERVBFTkRTPQltYWtlbWU6JHtQT1JU U0RJUn0vZGV2ZWwvbXNyYzAgXAogCQlta2NtZDoke1BPUlRTRElSfS9kZXZlbC9ta2NtZAog CitVU0VfUkNfU1VCUj0JY29uc2VydmVyCisKIE1BTjU9CQljb25zZXJ2ZXIuY2YuNQogTUFO OD0JCWF1dG9sb2dpbi44IGNvbnNvbGUuOCBjb25zZXJ2ZXIuOAogCkBAIC02NCwxMCArNjYs NiBAQAogCSAgICAke1BSRUZJWH0vbWFuL21hbjgvYXV0b2xvZ2luLjggIFwKIAkgICAgJHtQ UkVGSVh9L21hbi9tYW44L2NvbnNlcnZlci44ICBcCiAJICAgICR7UFJFRklYfS9tYW4vbWFu OC9jb25zb2xlLjgKLS5pZiAhZXhpc3RzKCR7UFJFRklYfS9ldGMvcmMuZC9jb25zZXJ2ZXIu c2gpCi0JQCR7RUNIT19NU0d9ICJJbnN0YWxsaW5nICR7UFJFRklYfS9ldGMvcmMuZC9jb25z ZXJ2ZXIuc2ggc3RhcnR1cCBmaWxlLiIKLQlAJHtJTlNUQUxMX1NDUklQVH0gLW0gNzUxICR7 RklMRVNESVJ9L2NvbnNlcnZlci5zaCAke1BSRUZJWH0vZXRjL3JjLmQKLS5lbmRpZgogCUAj CSR7Q0FUfSAke1BLR01FU1NBR0V9CiAKIC5pbmNsdWRlIDxic2QucG9ydC5taz4KSW5kZXg6 IHBrZy1wbGlzdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvdXNyL2xvY2FsL25jdnMvcG9y dHMvY29tbXMvY29uc2VydmVyL3BrZy1wbGlzdCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41 CmRpZmYgLXUgLXIxLjUgcGtnLXBsaXN0Ci0tLSBwa2ctcGxpc3QJMjMgTm92IDIwMDAgMTI6 MDM6MzUgLTAwMDAJMS41CisrKyBwa2ctcGxpc3QJMTEgSnVuIDIwMDggMDE6MzI6MjQgLTAw MDAKQEAgLTEsNiArMSw1IEBACiBAY29tbWVudCAkRnJlZUJTRDogcG9ydHMvY29tbXMvY29u c2VydmVyL3BrZy1wbGlzdCx2IDEuNSAyMDAwLzExLzIzIDEyOjAzOjM1IG9icmllbiBFeHAg JAogYmluL2NvbnNvbGUKIGV0Yy9jb25zZXJ2ZXIuY2YuZWcKLWV0Yy9yYy5kL2NvbnNlcnZl ci5zaAogc2Jpbi9hdXRvbG9naW4KIHNiaW4vY29uc2VydmVyCg== --------------010108000606070408080901 Content-Type: text/plain; name="conserver.in" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="conserver.in" IyEvYmluL3NoCgojICRGcmVlQlNEOiBwb3J0cy9jb21tcy9jb25zZXJ2ZXIvZmlsZXMvY29u c2VydmVyLnNoLHYgMS41IDIwMDgvMDYvMTAgMTk6Mjg6MDYgY3kgRXhwICQKCiMgUFJPVklE RToJY29uc2VydmVyCiMgUkVRVUlSRToJTE9HSU4KIyBLRVlXT1JEOglzaHV0ZG93bgoKIyBU byBlbmFibGUgY29uc2VydmVyLCBhZGQgbGluZXMgbGlrZSBiZWxvdyB0byAvZXRjL3JjLmNv bmYuCiMKIyBjb25zZXJ2ZXJfZW5hYmxlPSJZRVMiCiMgY29uc2VydmVyX2ZsYWdzPSJPbmx5 IGFkZCBpZiBuZWVkZWQiCgouICUlUkNfU1VCUiUlCgpuYW1lPWNvbnNlcnZlcgpyY3Zhcj1g c2V0X3JjdmFyYAoKY29tbWFuZD0lJVBSRUZJWCUlL3NiaW4vY29uc2VydmVyCnJlcXVpcmVk X2ZpbGVzPSRjb25zZXJ2ZXJfY29uZgoKbG9hZF9yY19jb25maWcgJG5hbWUKCmNvbnNlcnZl cl9lbmFibGU9JHtjb25zZXJ2ZXJfZW5hYmxlLSJubyJ9CmNvbnNlcnZlcl9jb25mPSR7Y29u c2VydmVyX2NvbmYtIiUlUFJFRklYJSUvZXRjL2NvbnNlcnZlci5jZiJ9Cgpjb21tYW5kX2Fy Z3M9Ii1kIC1uIC1DICR7Y29uc2VydmVyX2NvbmZ9IgoKcnVuX3JjX2NvbW1hbmQgIiQxIgoK ZXhpdCAwCg== --------------010108000606070408080901--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?484F2D41.2010005>