Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jun 2016 17:09:34 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Brooks Davis <brooks@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r302094 - in head/sys: compat/freebsd32 kern
Message-ID:  <5096414.4TN0ypqLNM@ralph.baldwin.cx>
In-Reply-To: <201606222115.u5MLFxBD093628@repo.freebsd.org>
References:  <201606222115.u5MLFxBD093628@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, June 22, 2016 09:15:59 PM Brooks Davis wrote:
> Author: brooks
> Date: Wed Jun 22 21:15:59 2016
> New Revision: 302094
> URL: https://svnweb.freebsd.org/changeset/base/302094
> 
> Log:
>   Mark the pipe() system call as COMPAT10.
>   
>   As of r302092 libc uses pipe2() with a zero flags value instead of pipe().
>   
>   Commit with regenerated files and implementation to follow.

This breaks the build on at least i386 because other ABIs depend on being
able to call sys_pipe directly.  You should at least add COMPAT_FREEBSD10
to GENERIC on architectures that shipped a 10.x release.  That will fix the
build breakage on i386, but it's also the policy we follow for all the other
compat knobs.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5096414.4TN0ypqLNM>