Date: Tue, 8 Jun 2021 15:32:50 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Gleb Popov <6yearold@gmail.com> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f31a4d9f43ab - main - editors/xed: the port had been updated and changed (+) Message-ID: <YL%2BNolJi8h0lA1BN@FreeBSD.org> In-Reply-To: <CALH631=gPNewg3p6D30X5dBLBPgv8yAo9Ke6RkwvofahArToHg@mail.gmail.com> References: <202106081109.158B9949075935@gitrepo.freebsd.org> <CALH631mQWHm%2B9pcT%2BwAuPdcSs7WOBpzWMkpeye5qAO7qGOoN9A@mail.gmail.com> <YL9XUZaYysBY6ZyS@FreeBSD.org> <CALH631=gPNewg3p6D30X5dBLBPgv8yAo9Ke6RkwvofahArToHg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 08, 2021 at 03:00:06PM +0300, Gleb Popov wrote: > On Tue, Jun 8, 2021 at 2:41 PM Alexey Dokuchaev wrote: > > On Tue, Jun 08, 2021 at 02:22:26PM +0300, Gleb Popov wrote: > > > On Tue, Jun 8, 2021 at 2:09 PM Alexey Dokuchaev wrote: > > > > commit f31a4d9f43abb0e189bbc4a710268dc6a82c05a9 > > > > > > > > editors/xed: the port had been updated and changed (+) > > > > > > What does (+) mean in your notation? > > > > It means that the first line is not a real commit log and could be > > safely omitted (it does not carry any useful information) and that > > the real log follows below. > > Makes sense, although I'd put "Update to 3.0.0" into the first line and > list all other changes below. In this particular case it would be appropriate, but often update is not the most important part of the commit. For example, in 082ab5c87d31012c there is an update and a bugfix, but it's actually the bugfix that brings the most noticeable UX improvements. Since I prefer to make more rare, but more significant commits, "subject" model often does not quite suit this model and just gets in the way. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YL%2BNolJi8h0lA1BN>