Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Sep 2014 13:56:06 +0000 (UTC)
From:      "Alexander V. Chernikov" <melifaro@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r271165 - projects/ipfw/sbin/ipfw
Message-ID:  <201409051356.s85Du66k027240@svn.freebsd.org>

index | next in thread | raw e-mail

Author: melifaro
Date: Fri Sep  5 13:56:05 2014
New Revision: 271165
URL: http://svnweb.freebsd.org/changeset/base/271165

Log:
  Return setsockopt() directly.
  
  Suggested by:	Steven Hartland  at killing@multiplay.co.uk.

Modified:
  projects/ipfw/sbin/ipfw/ipfw2.c

Modified: projects/ipfw/sbin/ipfw/ipfw2.c
==============================================================================
--- projects/ipfw/sbin/ipfw/ipfw2.c	Fri Sep  5 13:52:39 2014	(r271164)
+++ projects/ipfw/sbin/ipfw/ipfw2.c	Fri Sep  5 13:56:05 2014	(r271165)
@@ -575,7 +575,6 @@ do_cmd(int optname, void *optval, uintpt
 int
 do_set3(int optname, ip_fw3_opheader *op3, uintptr_t optlen)
 {
-	int error;
 
 	if (co.test_only)
 		return (0);
@@ -587,9 +586,7 @@ do_set3(int optname, ip_fw3_opheader *op
 
 	op3->opcode = optname;
 
-	error = setsockopt(ipfw_socket, IPPROTO_IP, IP_FW3, op3, optlen);
-
-	return (error);
+	return (setsockopt(ipfw_socket, IPPROTO_IP, IP_FW3, op3, optlen));
 }
 
 /*


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409051356.s85Du66k027240>