Date: Mon, 13 Apr 2026 20:38:27 +0200 From: Daniel Engberg <diizzy@FreeBSD.org> To: Kenneth Raplee <kenrap@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Cc: Celeste Ornato <celeste@ornato.com>, Max Brazhnikov <makc@freebsd.org>, Gleb Popov <arrowd@freebsd.org> Subject: Re: git: 6fb8923e6ee4 - main - net-im/vesktop: New port Message-ID: <2bd5f43e-c5bd-4754-afad-7e11b8aa7b82@FreeBSD.org> In-Reply-To: <69dccf3e.33ce7.3b6a1844@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 2026-04-13 13:10, Kenneth Raplee wrote: > The branch main has been updated by kenrap: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=6fb8923e6ee4571046330ebf4b03a5f8a95c5c52 > > commit 6fb8923e6ee4571046330ebf4b03a5f8a95c5c52 > Author: Celeste Ornato <celeste@ornato.com> > AuthorDate: 2026-04-02 00:24:26 +0000 > Commit: Kenneth Raplee <kenrap@FreeBSD.org> > CommitDate: 2026-04-13 11:09:53 +0000 > > net-im/vesktop: New port > > Vesktop is a custom Discord App aiming to give you better performance > and improved Unix-like support. > > PR: 294195 > Co-authored-by: Kenneth Raplee <kenrap@FreeBSD.org> > Reviewed by: makc (mentor) > Approved by: arrowd (co-mentor) > --- > net-im/vesktop/Makefile | 43 ++++++++++++++++++++++++++ > net-im/vesktop/distinfo | 3 ++ > net-im/vesktop/pkg-descr | 5 +++ > net-im/vesktop/pkg-plist | 79 ++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 130 insertions(+) Hi, A port should never extract directly into WRKDIR as this can cause various issues including with the framework itself. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-no_wrksubdir I also don't see any reviews or approvals in the PR or on Phab? You can also do a custom do-extract to avoid shuffling around 90Mbyte of data. See PR 294489, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294489 Best regards, Danielhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2bd5f43e-c5bd-4754-afad-7e11b8aa7b82>