Date: Thu, 28 Apr 2022 20:39:55 -0700 From: Mark Millard <marklmi@yahoo.com> Cc: freebsd-current <freebsd-current@freebsd.org>, "freebsd-arm@freebsd.org" <arm@freebsd.org> Subject: Re: sys/arm/broadcom/bcm2835/bcm2838_xhci.c:184:21: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] Message-ID: <E876F173-C2D7-4BC8-98B0-A48E5AE53E2A@yahoo.com> In-Reply-To: <D3A0943B-DDB8-45F7-ADD5-04B41336A4F6@yahoo.com> References: <D3A0943B-DDB8-45F7-ADD5-04B41336A4F6.ref@yahoo.com> <D3A0943B-DDB8-45F7-ADD5-04B41336A4F6@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
IGNORE.
On 2022-Apr-28, at 20:33, Mark Millard <marklmi@yahoo.com> wrote:
> In attempting to update from main-n253904-4d1ba6febfa7 based to
> main-n255108-9fb40baf6043 based, targeting aarch64, the following
> code from sys/arm/broadcom/bcm2835/bcm2838_xhci.c was rejected:
>=20
> static int
> bcm_xhci_attach(device_t dev)
> {
> struct xhci_softc *sc;
> int error;
>=20
> sc =3D device_get_softc(dev);
>=20
> bcm_xhci_install_xhci_firmware(dev);
>=20
> error =3D xhci_pci_attach(dev);
> return (error);
> }
>=20
> as follows:
>=20
> --- bcm2838_xhci.o ---
> /usr/main-src/sys/arm/broadcom/bcm2835/bcm2838_xhci.c:184:21: error: =
variable 'sc' set but not used [-Werror,-Wunused-but-set-variable]
> struct xhci_softc *sc;
> ^
> Building =
/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/sys/GENER=
IC-NODBG-CA72/imx_i2c.o
> 1 error generated.
> *** [bcm2838_xhci.o] Error code 1
>=20
> make[2]: stopped in =
/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/sys/GENER=
IC-NODBG-CA72
> .ERROR_TARGET=3D'bcm2838_xhci.o'
> =
.ERROR_META_FILE=3D'/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm=
64.aarch64/sys/GENERIC-NODBG-CA72/bcm2838_xhci.o.meta'
> .MAKE.LEVEL=3D'2'
> MAKEFILE=3D''
> .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes=
verbose curdirOk=3Dyes'
> _ERROR_CMD=3D'cc -target aarch64-unknown-freebsd14.0 =
--sysroot=3D/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch=
64/tmp =
-B/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/tmp/usr=
/bin -c -O2 -pipe -fno-strict-aliasing -g -nostdinc -I. =
-I/usr/main-src/sys -I/usr/main-src/sys/contrib/ck/include =
-I/usr/main-src/sys/contrib/libfdt =
-I/usr/main-src/sys/contrib/device-tree/include -D_KERNEL =
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common =
-mcpu=3Dcortex-a72 -DLINUX_DTS_VERSION=3D\""5.13"\" =
-mstack-protector-guard=3Dsysreg -mstack-protector-guard-reg=3Dsp_el0 =
-mstack-protector-guard-offset=3D0 -fno-omit-frame-pointer =
-mno-omit-leaf-frame-pointer =
-fdebug-prefix-map=3D./machine=3D/usr/main-src/sys/arm64/include =
-mgeneral-regs-only -ffixed-x18 -ffreestanding -fwrapv -fstack-protector =
-Wall -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes =
-Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign =
-D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs =
-fdiagnostics-show-option -Wno-unknown-pragmas =
-Wno-error=3Dtautological-compare -Wno-error=3Dempty-body =
-Wno-error=3Dparentheses-equality -Wno-error=3Dunused-function =
-Wno-error=3Dpointer-sign -Wno-error=3Dshift-negative-value =
-Wno-address-of-packed-member -Wno-format-zero-length -mcpu=3Dcortex-a72=
-std=3Diso9899:1999 -Werror =
/usr/main-src/sys/arm/broadcom/bcm2835/bcm2838_xhci.c; ctfconvert -L =
VERSION -g bcm2838_xhci.o;'
> =
.CURDIR=3D'/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch6=
4/sys/GENERIC-NODBG-CA72'
> .MAKE=3D'make'
> =
.OBJDIR=3D'/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch6=
4/sys/GENERIC-NODBG-CA72'
> .TARGETS=3D'all'
> DESTDIR=3D''
> LD_LIBRARY_PATH=3D''
> MACHINE=3D'arm64'
> MACHINE_ARCH=3D'aarch64'
> MAKEOBJDIRPREFIX=3D''
> MAKESYSPATH=3D'/usr/main-src/share/mk'
> MAKE_VERSION=3D'20220208'
> =
PATH=3D'/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/t=
mp/bin:/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/tm=
p/usr/sbin:/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch6=
4/tmp/usr/bin:/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aar=
ch64/tmp/legacy/usr/sbin:/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-sr=
c/arm64.aarch64/tmp/legacy/usr/bin:/usr/obj/BUILDs/main-CA72-nodbg-clang/u=
sr/main-src/arm64.aarch64/tmp/legacy/bin:/usr/obj/BUILDs/main-CA72-nodbg-c=
lang/usr/main-src/arm64.aarch64/tmp/legacy/usr/libexec::/sbin:/bin:/usr/sb=
in:/usr/bin'
> SRCTOP=3D'/usr/main-src'
> OBJTOP=3D'/usr/main-src'
> .MAKE.MAKEFILES=3D'/usr/main-src/share/mk/sys.mk =
/usr/main-src/share/mk/local.sys.env.mk =
/usr/main-src/share/mk/src.sys.env.mk =
/usr/home/root/src.configs/src.conf.CA72-nodbg-clang.aarch64-host =
/usr/main-src/share/mk/bsd.mkopt.mk =
/usr/main-src/share/mk/src.sys.obj.mk /usr/main-src/share/mk/auto.obj.mk =
/usr/main-src/share/mk/bsd.suffixes.mk =
/usr/home/root/src.configs/make.conf /usr/main-src/share/mk/local.sys.mk =
/usr/main-src/share/mk/src.sys.mk /dev/null Makefile =
/usr/main-src/sys/conf/kern.pre.mk /usr/main-src/share/mk/bsd.own.mk =
/usr/main-src/share/mk/bsd.opts.mk /usr/main-src/share/mk/bsd.cpu.mk =
/usr/main-src/share/mk/bsd.compiler.mk =
/usr/main-src/share/mk/bsd.endian.mk =
/usr/main-src/share/mk/bsd.linker.mk /usr/main-src/sys/conf/kern.opts.mk =
/usr/main-src/sys/conf/kern.post.mk /usr/main-src/sys/conf/kern.mk'
> .PATH=3D'. =
/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/sys/GENER=
IC-NODBG-CA72'
> 1 error
>=20
This is because of my experimental patches for RPi4 related
issues. Sorry for the noise.
=3D=3D=3D
Mark Millard
marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E876F173-C2D7-4BC8-98B0-A48E5AE53E2A>