Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Jan 2026 18:44:25 +0000
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 9cdd58d51d49 - stable/14 - ctld: Fix sign bug validating kernel ports when reloading config
Message-ID:  <69790789.21100.5ba7b26@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/14 has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=9cdd58d51d49503e1066875470014c992937471b

commit 9cdd58d51d49503e1066875470014c992937471b
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2025-04-11 13:59:24 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2026-01-27 18:15:57 +0000

    ctld: Fix sign bug validating kernel ports when reloading config
    
    When I switched new_pports_from_conf to return bool instead of an
    inverted int, I missed updating the call after reloading the config
    file due to SIGHUP.
    
    Fixes:          450a84c292ae ("ctld: Some bool-related cleanups")
    Sponsored by:   Chelsio Communications
    Differential Revision:  https://reviews.freebsd.org/D49641
    (cherry picked from commit e7611b7531c4fc6d26d36faad79088f277af78f0)
---
 usr.sbin/ctld/ctld.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr.sbin/ctld/ctld.cc b/usr.sbin/ctld/ctld.cc
index 07e262915975..eb873acda59e 100644
--- a/usr.sbin/ctld/ctld.cc
+++ b/usr.sbin/ctld/ctld.cc
@@ -2602,7 +2602,7 @@ main(int argc, char **argv)
 			if (tmpconf == NULL) {
 				log_warnx("configuration error, "
 				    "continuing with old configuration");
-			} else if (new_pports_from_conf(tmpconf, &kports)) {
+			} else if (!new_pports_from_conf(tmpconf, &kports)) {
 				log_warnx("Error associating physical ports, "
 				    "continuing with old configuration");
 				conf_delete(tmpconf);


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69790789.21100.5ba7b26>