Date: Tue, 09 Jun 2020 20:25:34 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Doug Moore <dougm@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r361997 - head/sys/sys Message-ID: <44549A88-B566-4D5E-AA3E-97CF4C44C8BC@panasas.com> In-Reply-To: <202006100250.05A2oQ4v080988@repo.freebsd.org> References: <202006100250.05A2oQ4v080988@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Doug,
Shoot, it's still failing, but in a different way:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
/usr/home/rpokala/freebsd/dev/base/head/sys/kern/subr_stats.c:3385:14: erro=
r: expected ')'
qstr);
^
/usr/home/rpokala/freebsd/dev/base/head/sys/kern/subr_stats.c:3375:11: note=
: to match this '('
printf(" RB ctd=3D%3d p=3D%3d l=3D%3d r=3D%3d c=3D%2d=
"
^
1 error generated.
--- subr_stats.o ---
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Thanks,
Ravi (rpokala@)
=EF=BB=BF-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Doug Moore <dougm@Fre=
eBSD.org>
Date: 2020-06-09, Tuesday at 19:50
To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@=
freebsd.org>
Subject: svn commit: r361997 - head/sys/sys
Author: dougm
Date: Wed Jun 10 02:50:25 2020
New Revision: 361997
URL: https://svnweb.freebsd.org/changeset/base/361997
Log:
Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC cod=
e
that depends on it.
Reported by: rpokala, mjguzik
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D25204
Modified:
head/sys/sys/tree.h
Modified: head/sys/sys/tree.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D
--- head/sys/sys/tree.h Wed Jun 10 01:32:13 2020 (r361996)
+++ head/sys/sys/tree.h Wed Jun 10 02:50:25 2020 (r361997)
@@ -333,6 +333,12 @@ struct { \
#define RB_TRUE 1
#define RB_FALSE 0
+/* For debugging support */
+#define RB_COLOR(elm, field) (RB_PARENT(elm, field) =3D=3D NULL ? RB_FALS=
E : \
+ RB_LEFT(RB_PARENT(elm, field), field) =3D=3D elm ? \
+ RB_RED_LF(RB_PARENT(elm, field), field) : \
+ RB_RED_RT(RB_PARENT(elm, field), field)
+
/*
* Something to be invoked in a loop at the root of every modified sub=
tree,
* from the bottom up to the root, to update augmented node data.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44549A88-B566-4D5E-AA3E-97CF4C44C8BC>