Date: Wed, 13 May 2015 11:00:07 -0400 From: Ed Maste <emaste@freebsd.org> To: Marko Turk <markoml@markoturk.info> Cc: freebsd-stable stable <freebsd-stable@freebsd.org>, "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org> Subject: Re: vt_core.c vt_is_cursor_in_area different behavior after r282823 Message-ID: <CAPyFy2A2JDCW5=oRnJGRzGuaBpBViherxK6mzMddvXXKoa0Hog@mail.gmail.com> In-Reply-To: <20150513070259.GA27935@vps.markoturk.info> References: <20150513070259.GA27935@vps.markoturk.info>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 May 2015 at 03:02, Marko Turk <markoml@markoturk.info> wrote: > Hi, > > after r282823, new vt_is_cursor_in_area is, in some cases, returning > different values than the old function. > > For example: > If (my + vd->vd_mcursor->height) is equal to (area->tr_begin.tp_row), > old function will return 1 and new function will return 0. > > Is this intended behavior or is it a bug? Thanks for the detailed look at the change! It's intentional -- when they're equal the cursor rectangle and display area rectangle border each other, but do not actually overlap. It doesn't hurt to return 1 in this case, it just results in some unnecessary drawing.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2A2JDCW5=oRnJGRzGuaBpBViherxK6mzMddvXXKoa0Hog>