Date: Fri, 12 Mar 2010 10:58:20 -0800 From: Julian Elischer <julian@elischer.org> To: obrien@freebsd.org Cc: FreeBSD Current <current@freebsd.org> Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 Message-ID: <4B9A8ECC.6040503@elischer.org> In-Reply-To: <20100312171758.GB31089@dragon.NUXI.org> References: <4B991C00.3010809@intertainservices.com> <790a9fff1003111714s58d9ee4bl6454d1d52bf705b8@mail.gmail.com> <7d6fde3d1003111720g7dccf93w1f51db88758a5c4d@mail.gmail.com> <20100311.192423.683591382013853731.imp@bsdimp.com> <20100312171758.GB31089@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote: > Yes names matter. Otherwise we would have made it "DEF8931". #define > names are chosen to be self-documenting. > > $ grep COMPAT_FREEBSD conf/* > conf/NOTES:# Note that as a general rule, COMPAT_FREEBSD<n> depends on > conf/NOTES:# COMPAT_FREEBSD<n+1>, COMPAT_FREEBSD<n+2>, etc. > conf/NOTES:options COMPAT_FREEBSD4 > conf/NOTES:options COMPAT_FREEBSD5 > conf/NOTES:options COMPAT_FREEBSD6 > conf/NOTES:options COMPAT_FREEBSD7 > conf/options:COMPAT_FREEBSD4 opt_compat.h > conf/options:COMPAT_FREEBSD5 opt_compat.h > conf/options:COMPAT_FREEBSD6 opt_compat.h > conf/options:COMPAT_FREEBSD7 opt_compat.h > > COMPAT_FREEBSD32 is not the same as any of the other well established > "COMPAT_FREEBSD" macros. So I do see where this could lead to confusion > to users. > just add BIT on the end.. COMPAT_FREEBSD32BIT
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B9A8ECC.6040503>