Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Nov 2008 13:44:22 GMT
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 153605 for review
Message-ID:  <200811261344.mAQDiMZF040841@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=153605

Change 153605 by trasz@trasz_victim7 on 2008/11/26 13:43:55

	Make sure we really require WRITE_OWNER in order to change owner.

Affected files ...

.. //depot/projects/soc2008/trasz_nfs4acl/tools/regression/fstest/tests/granular/04.t#2 edit

Differences ...

==== //depot/projects/soc2008/trasz_nfs4acl/tools/regression/fstest/tests/granular/04.t#2 (text+ko) ====

@@ -5,7 +5,7 @@
 dir=`dirname $0`
 . ${dir}/../misc.sh
 
-echo "1..44"
+echo "1..52"
 
 n0=`namegen`
 n1=`namegen`
@@ -17,16 +17,24 @@
 
 # ACL_WRITE_OWNER permits to set gid to our own only.
 expect 0 create ${n0} 0644
+expect 0,0 lstat ${n0} uid,gid
+expect EPERM -u 65534 -g 65532,65531 chown ${n0} -1 65532
+expect 0,0 lstat ${n0} uid,gid
 expect 0 prependacl ${n0} user:65534:write_owner::allow
-expect 0,0 lstat ${n0} uid,gid
 expect EPERM -u 65534 -g 65532,65531 chown ${n0} -1 65530
 expect 0,0 lstat ${n0} uid,gid
 expect 0 -u 65534 -g 65532,65531 chown ${n0} -1 65532
 expect 0,65532 lstat ${n0} uid,gid
+expect 0 unlink ${n0}
 
 # ACL_WRITE_OWNER permits to set uid to our own only.
+expect 0 create ${n0} 0644
+expect 0,0 lstat ${n0} uid,gid
+expect EPERM -u 65534 -g 65532,65531 chown ${n0} 65534 65531
+expect 0,0 lstat ${n0} uid,gid
+expect 0 prependacl ${n0} user:65534:write_owner::allow
 expect EPERM -u 65534 -g 65532,65531 chown ${n0} 65530 65531
-expect 0,65532 lstat ${n0} uid,gid
+expect 0,0 lstat ${n0} uid,gid
 expect 0 -u 65534 -g 65532,65531 chown ${n0} 65534 65531
 expect 65534,65531 lstat ${n0} uid,gid
 expect 0 unlink ${n0}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811261344.mAQDiMZF040841>