Date: Wed, 19 Feb 2014 14:01:23 +0100 From: Martin Matuska <mm@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis <nvass@gmx.com>, src-committers@freebsd.org Subject: Re: svn commit: r262196 - head/sys/netpfil/pf Message-ID: <20140219140123.Horde.zrXx5GqkiiaAfGIetc98KQ1@mail.vx.sk> In-Reply-To: <20140219101736.GX63039@glebius.int.ru> References: <201402182217.s1IMHCeM077356@svn.freebsd.org> <20140219101736.GX63039@glebius.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Gleb, I understand your point - if anything is broken (or more broken than before) I can revert this patch anytime. FreeNAS and other folks may fork separate branches and we can wait until about FreeBSD 12.0 for the patch being reviewed so we can commit it around 14.0 - maybe we have switched to a completely different firewall at that time and this issue becomes obsolete anyway. Best regards, mm Quoting Gleb Smirnoff <glebius@freebsd.org>: > Martin, > > On Tue, Feb 18, 2014 at 10:17:12PM +0000, Martin Matuska wrote: > M> Author: mm > M> Date: Tue Feb 18 22:17:12 2014 > M> New Revision: 262196 > M> URL: http://svnweb.freebsd.org/changeset/base/262196 > M> > M> Log: > M> De-virtualize pf_mtag_z [1] > M> Process V_pf_overloadqueue in vnet context [2] > M> > M> This fixes two VIMAGE kernel panics and allows to simultaneously > run host-pf > M> and vnet jails. pf inside jails remains broken. > M> > M> PR: kern/182964 > M> Submitted by: glebius@FreeBSD.org [2], myself [1] > M> Tested by: rodrigc@FreeBSD.org, myself > M> MFC after: 2 weeks > > I've sent your patch to Nikos, who is working on pf+vimage. He > also accumulates his work on pf+vimage in projects/pf branch, > planning to do it properly and then merge to head in one go. > I was waiting for his review. Yes, he is slow with reviews, > but that's not a reason to commit w/o review. > > --Totus tuus, Glebius. -- Martin Matuska FreeBSD committer http://blog.vx.sk
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140219140123.Horde.zrXx5GqkiiaAfGIetc98KQ1>