Date: Mon, 25 Feb 2002 18:25:42 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, hackers@FreeBSD.org Subject: Re: <sys/types.h> or not <sys/types.h>? [Was: cvs commit: src/include grp.h] Message-ID: <20020225152541.GA35289@nagual.pp.ru> In-Reply-To: <20020225142352.GA34378@nagual.pp.ru> References: <200202251355.g1PDtmb35078@freefall.freebsd.org> <20020225140030.GD33818@nagual.pp.ru> <3C7A458F.427FFF8A@FreeBSD.org> <20020225142352.GA34378@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 25, 2002 at 17:23:53 +0300, Andrey A. Chernov wrote: > Your initial fix was incorrect, but intention was right. <grp.h> should > declare gid_t by itself. Sample quotes included below. > > >From IEEE P1003.1 Draft 7: > > NAME > 8332 grp.h.group structure > 8342 The gid_t type shall be defined as described in <sys/types.h>. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I mean that the fix with less header pollution will be something like: #ifndef _GID_T_DECLARED typedef ... #define _GID_T_DECLARED #endif in _both_ <grp.h> and <sys/types.h> (you need to include <machine/ansi.h> in <grp.h> in anycase) But for simpler solution your fix is enough. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020225152541.GA35289>