Date: Sun, 15 Jul 2018 11:26:00 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: "K. Macy" <kmacy@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715182600.GB31164@troutmask.apl.washington.edu> In-Reply-To: <CAHM0Q_OMYUe4CDemC8Gx9AGzA%2BwK0cctwUhHieeQi2xdDs0urA@mail.gmail.com> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> <CAHM0Q_OMYUe4CDemC8Gx9AGzA%2BwK0cctwUhHieeQi2xdDs0urA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 15, 2018 at 10:21:25AM -0700, K. Macy wrote: > > > > Well, actually, the functions in polevll.c should have been copied > > into ld80/e_powl.c, and polevall.c should never have been committed. > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > Baldwin were both looped in. Neither made this observation. I read the differential review. The code was not reviewed by John. He reviewed how it was hooked into the build. Bruce does not appear in the differential review. There is no record on freebsd-numerics about the patch. powl on i686-class hardware is likely broken as it does not use the LD80C macro to construct literal constants. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180715182600.GB31164>