Date: Wed, 13 Dec 2017 06:56:33 +0000 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Warner Losh <imp@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r326809 - head/sys/dev/cardbus Message-ID: <CANCZdfqydK4iY0dOwcUKTb8u8G5w6waqgSBgRzxZeSGd5nOvKg@mail.gmail.com> In-Reply-To: <20171213065443.GA31341@FreeBSD.org> References: <201712122022.vBCKM9Kd050769@repo.freebsd.org> <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net> <20171213065443.GA31341@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 13, 2017 at 6:54 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > > New Revision: 326809 > > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > > > Log: > > > 1k objects on the stack are a bad idea. While it's likely safe in > this > > > context, it's also safe to allocate the memory and free it instead. > > > > > > Noticed by: Eugene Grosbein's script > > > > YEA!!! One down, 20 to go and then see how the kstack issue does? > > > > And thank you for quickly fixing this. > > It's very promising to see debloat-type of work having started. On the > related note, what is current consensus with r326758, is it going to be > backed out and stack issues investigated and fixed? I am worried since > kib@ had mentioned that he's "almost sure that [32-bit x86 workstation] > users would get troubles now" [*] and I'm one of them. > I have fixes for 2 or 3 cam ones, and plans to fix another 3 or 4 of the remaining ones which are easy. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqydK4iY0dOwcUKTb8u8G5w6waqgSBgRzxZeSGd5nOvKg>