Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Sep 2012 20:02:08 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        mdf@freebsd.org
Cc:        svn-src-head@freebsd.org, Aleksandr Rybalko <ray@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r240067 - head/sys/kern
Message-ID:  <20120903170208.GQ33100@deviant.kiev.zoral.com.ua>
In-Reply-To: <CAMBSHm93ct9GCc_S6D8N15bAkitU3jTWr2_5P5Z4maQ5oim8PQ@mail.gmail.com>
References:  <201209030852.q838q6lC053405@svn.freebsd.org> <CAMBSHm93ct9GCc_S6D8N15bAkitU3jTWr2_5P5Z4maQ5oim8PQ@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Mon, Sep 03, 2012 at 09:09:08AM -0700, mdf@freebsd.org wrote:
> On Mon, Sep 3, 2012 at 1:52 AM, Aleksandr Rybalko <ray@freebsd.org> wrote:
> > Author: ray
> > Date: Mon Sep  3 08:52:05 2012
> > New Revision: 240067
> > URL: http://svn.freebsd.org/changeset/base/240067
> >
> > Log:
> >   Add kern.hintmode sysctl variable to show current state of hints:
> >   0 - loader hints in environment only;
> >   1 - static hints only
> >   2 - fallback mode (Dynamic KENV with fallback to kernel environment)
> >   Add kern.hintmode write handler, accept only value 2. That will switch
> >   static KENV to dynamic. So it will be possible to change device hints.
> >
> >   Approved by:  adrian (mentor)
> >
> > Modified:
> >   head/sys/kern/subr_hints.c
> >
> > Modified: head/sys/kern/subr_hints.c
> > ==============================================================================
> > --- head/sys/kern/subr_hints.c  Mon Sep  3 07:18:24 2012        (r240066)
> > +++ head/sys/kern/subr_hints.c  Mon Sep  3 08:52:05 2012        (r240067)
> > @@ -29,8 +29,10 @@ __FBSDID("$FreeBSD$");
> >
> >  #include <sys/param.h>
> >  #include <sys/lock.h>
> > +#include <sys/malloc.h>
> >  #include <sys/mutex.h>
> >  #include <sys/systm.h>
> > +#include <sys/sysctl.h>
> 
> Putting on my style-nazi hat.  sysctl comes before systm alphabetically.
Systm.h is very special, it normally comes as the second item in the
include list, right after param.h.

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAlBE4o8ACgkQC3+MBN1Mb4iZlACg6lqUQVLihrkHcVsiKwpshl49
5oQAn3HCfbwiU3OQiIKc3gdFP7uF77OS
=niOP
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120903170208.GQ33100>