Date: Wed, 5 Jan 2005 11:05:38 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: scottl@FreeBSD.org Subject: Re: BigDisk project: du(1) 64bit clean. Message-ID: <20050105190538.GA8054@odin.ac.hmc.edu> In-Reply-To: <20050105102056.GO784@darkness.comp.waw.pl> References: <20050104224043.GM784@darkness.comp.waw.pl> <20050105030426.GB24604@odin.ac.hmc.edu> <20050105102056.GO784@darkness.comp.waw.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 05, 2005 at 11:20:56AM +0100, Pawel Jakub Dawidek wrote: > On Tue, Jan 04, 2005 at 07:04:26PM -0800, Brooks Davis wrote: > +> I'd be inclined to use the somewhat gross fix in PR 74567 in RELENG_5 > +> and do it right in HEAD. [...] >=20 > It allocates memory and we don't need it. > Proposed fix is actually for RELENG_5. We can also do some magic inside > du(1) to split 64bit value between two fields (fts_number/fts_pointer) > when needed (on 32bit archs), but it would be really hackish. I missed the fact this this was for RELENG_5 only, this seems like a good solution there. > +> [...] bde suggested changing fts_num to intmax_t. >=20 > The only issue here is that we break ABI if intmax_t will be bumped to > 128bits in gcc, but we probably will have much bigger problems then:) > I like this idea. We'd have to bump nearly all library revs if we changed the the size of intmax_t since we'd break printing of 64-bit numbers. :-) -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --SUOF0GtieIMvvwua Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFB3DqCXY6L6fI4GtQRAua9AJ9XXp6JAGn2J+5cSubpY/pNBKP8LQCcCOae wsuORnnHA0USZc9T9QqJ9nA= =Uytx -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050105190538.GA8054>