Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Nov 2008 20:20:48 +0100
From:      Rink Springer <rink@FreeBSD.org>
To:        Ulf Lilleengen <lulf@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r185309 - head/sys/geom/vinum
Message-ID:  <20081125192048.GA12700@rink.nu>
In-Reply-To: <200811251913.mAPJDwrD032237@svn.freebsd.org>
References:  <200811251913.mAPJDwrD032237@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 25, 2008 at 07:13:58PM +0000, Ulf Lilleengen wrote:
> Author: lulf
> Date: Tue Nov 25 19:13:58 2008
> New Revision: 185309
> URL: http://svn.freebsd.org/changeset/base/185309
> 
> Log:
>   - Fix a potential NULL pointer reference. Note that this cannot happen in
>     practice, but it is a good programming practice nontheless and it allows the
>     kernel to not depend on userland correctness.

If it can't happen in practice, why not just ASSERT on them? This would
be useful for debugging, and it basically tells whoever reads the code
about the scenario's you are dealing with...

-- 
Rink P.W. Springer                                - http://rink.nu
"Anyway boys, this is America. Just because you get more votes doesn't
 mean you win." - Fox Mulder



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081125192048.GA12700>