Date: Tue, 14 Dec 2004 11:26:05 GMT From: Volker Stolz <vs@FreeBSD.org> To: cartola@openit.com.br, vs@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/71846: New port: graphics/libpano12 - program to mount panorama pictures - also a dependency to hugin Message-ID: <200412141126.iBEBQ5gv091246@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: New port: graphics/libpano12 - program to mount panorama pictures - also a dependency to hugin
State-Changed-From-To: open->feedback
State-Changed-By: vs
State-Changed-When: Tue Dec 14 10:51:32 GMT 2004
State-Changed-Why:
- Please use portlint, it will tell you that you must use tabs,
not spaces
- Please use MASTER_SITES=${MASTER_SITE_SOURCEFORGE} /
MASTER_SITE_SUBDIR=panotools
- USE_BZIP=yes since that distfile is smaller
- LDCONFIG_DIRS already contains the right value!
- You could use %%DOCSDIR%% in pkg-plist
- Why don't you use the included "configure"?
- Hardcoded CC/CFLAGS in your custom makefile
- -fPIC doesn't look right
- trivial upgrade to recent version 2.7.0.8
- Please use bsd.java.mk v2.0, i.e.
USE_JAVA=yes
JAVA_VERSION=1.3+
- Missing file/dependency? PTDialogs.c:35:21: sys_x11.h: No such file or directory
Looks like a typo for sys_X11. Why do you only want to build
the ANSI-version anyway?
Please review my modifications at
http://www.foldr.org/~stolz/FreeBSD/libpano12.Makefile
You might want to surgically replace parts of Makefile.* with 'patch' to
limit what will actually be built instead of your hand-crafted Makefile.
Better yet: find out why it's falling over at all -- is there a way to
disable X11 instead of setting -D__ANSI__?
Cheers,
Volker
http://www.freebsd.org/cgi/query-pr.cgi?pr=71846
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200412141126.iBEBQ5gv091246>