Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Jul 2020 15:36:25 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Alexander Leidinger <netchild@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org
Subject:   Re: svn commit: r363125 - head/sys/compat/linux
Message-ID:  <010ACFFA-35B7-4984-A5E7-1504C72D56F9@FreeBSD.org>
In-Reply-To: <202007120951.06C9pA4F024281@repo.freebsd.org>
References:  <202007120951.06C9pA4F024281@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_3BE14362-335B-4C18-976D-6487A1EC1C5B
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 12 Jul 2020, at 11:51, Alexander Leidinger <netchild@freebsd.org> wrote:
> 
> Author: netchild
> Date: Sun Jul 12 09:51:09 2020
> New Revision: 363125
> URL: https://svnweb.freebsd.org/changeset/base/363125
> 
> Log:
>  Implement CLOCK_MONOTONIC_RAW (linux >= 2.6.28).
> 
>  It is documented as a raw hardware-based clock not subject to NTP or
>  incremental adjustments. With this "not as precise as CLOCK_MONOTONIC"
>  description in mind, map it to our CLOCK_MONOTNIC_FAST (the same
>  mapping as for the linux CLOCK_MONOTONIC_COARSE).

Okay, but:

> @@ -212,6 +212,7 @@ linux_to_native_clockid(clockid_t *n, clockid_t l)
> 		*n = CLOCK_THREAD_CPUTIME_ID;
> 		break;
> 	case LINUX_CLOCK_REALTIME_COARSE:
> +	case LINUX_CLOCK_MONOTONIC_RAW:
> 		*n = CLOCK_REALTIME_FAST;
> 		break;
> 	case LINUX_CLOCK_MONOTONIC_COARSE:

this shows it is actually mapped to CLOCK_REALTIME_FAST, not
CLOCK_MONOTONIC_FAST. Is the code right, or the commit message? :)

-Dimitry


--Apple-Mail=_3BE14362-335B-4C18-976D-6487A1EC1C5B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXwsR2QAKCRCwXqMKLiCW
oyk/AKCEcInURNI0bPCUNVoLlyIBbI8HPgCg97aWShFuMTdB6Lkhl5PB6PgwWQ8=
=m7ks
-----END PGP SIGNATURE-----

--Apple-Mail=_3BE14362-335B-4C18-976D-6487A1EC1C5B--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?010ACFFA-35B7-4984-A5E7-1504C72D56F9>